You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/02 08:06:11 UTC

[GitHub] [calcite] wenhuitang commented on a change in pull request #1275: [CALCITE-3136]Fix the default rule description of ConverterRule

wenhuitang commented on a change in pull request #1275: [CALCITE-3136]Fix the default rule description of ConverterRule
URL: https://github.com/apache/calcite/pull/1275#discussion_r299352046
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/convert/ConverterRule.java
 ##########
 @@ -78,7 +78,7 @@ public ConverterRule(Class<? extends RelNode> clazz, RelTrait in,
     super(convertOperand(clazz, predicate, in),
         relBuilderFactory,
         description == null
-            ? "ConverterRule<in=" + in + ",out=" + out + ">"
+            ? "ConverterRule(in:" + in + ",out:" + out + ")"
             : description);
 
 Review comment:
   = is not allowed in rule description, it would be better to use : 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services