[jira] Commented: (QPID-1319) Options for a broker (given in the broker list in the connection URL) should default to the top level values

["Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637525#action_12637525 ] 

Rajith Attapattu commented on QPID-1319:
----------------------------------------

Martin, appreciate your comments.

>The ssl option should only be attached to the entry in the brokerlist and not at the same level as brokerlist.
According to the wiki entry below that is not the case.
http://cwiki.apache.org/qpid/connection-url-format.html

More specifcally look at the following example given in the above wiki entry.
amqp://guest:guest@client/test?ssl='true'&brokerlist='tcp://localhost;tcp://redundant-server:5673?ssl='false''&failover='roundrobin'

I don't know which one is correct. What ever we do, we need to sync our documentation with the code.

> The change of the empty constructor to be totally empty highlights its weirdness, the fact that you can make the AMQBrokerDetails object in two different ways that result in two different objects
There is code in the client that does rely on the empty constructor. Look at URLParser_0_10.java line 198.
This code is not in any way weird than the previous version. 
If somebody called the argumentless constructor in the previous version it would have resulted in the same state. (i.e in the prev version the options was initialized in the constructor, in the new version it was init as a field).
Could you please explain how it is different now? (maybe I have missed something).

> Options for a broker (given in the broker list in the connection URL) should default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-1319
>                 URL: https://issues.apache.org/jira/browse/QPID-1319
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: M4
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>             Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) should default  to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get copied to individual broker level options.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.