You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/08 03:37:03 UTC

[GitHub] [flink] lonelyGhostisdog opened a new pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

lonelyGhostisdog opened a new pull request #13090:
URL: https://github.com/apache/flink/pull/13090


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   *support maxwell-json for Maxwell binlog collector*
   
   
   ## Brief change log
   
     - *add DeserializationSchema for deserialize byte[]*
     - *add SerializationSchema for serialize data to byte[]*
     - *add formatfactory for DeserializationSchema&SerializationSchema*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Added java tests for deserialize byte[] from table source & serialize data to byte[] into table sink*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: ( no )
     - The runtime per-record code paths (performance sensitive): ( no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: ( no )
     - The S3 file system connector: ( no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes )
     - If yes, how is the feature documented? ( docs / JavaDocs )
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3faa1b539faff3a59454cf9710ea69f4dd395e05 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong merged pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #13090:
URL: https://github.com/apache/flink/pull/13090


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] lonelyGhostisdog commented on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
lonelyGhostisdog commented on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-671680630


   > Besides, it would be great if you can add the corresponding documentation in this PR.
   > But create a following up JIRA issue is also fine to me.
   
   i will finish these bugs soon.
    Documentation will be add next PR . 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-672543906


   Build is passed. 
   Merging... 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] lonelyGhostisdog commented on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
lonelyGhostisdog commented on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-671750025


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "671003019",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "d2a7bde48d5c4e4106e9f889e0a3729c5a71c716",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5379",
       "triggerID" : "d2a7bde48d5c4e4106e9f889e0a3729c5a71c716",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c527896a27f2b12500b6b730ce07ab97ccbafff0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5403",
       "triggerID" : "c527896a27f2b12500b6b730ce07ab97ccbafff0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c527896a27f2b12500b6b730ce07ab97ccbafff0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5403) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3faa1b539faff3a59454cf9710ea69f4dd395e05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3faa1b539faff3a59454cf9710ea69f4dd395e05 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] lonelyGhostisdog removed a comment on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
lonelyGhostisdog removed a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-671752843


   > ## CI report:
   > * [d2a7bde](https://github.com/apache/flink/commit/d2a7bde48d5c4e4106e9f889e0a3729c5a71c716) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5379)
   > 
   > Bot commands
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "671003019",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "d2a7bde48d5c4e4106e9f889e0a3729c5a71c716",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5379",
       "triggerID" : "d2a7bde48d5c4e4106e9f889e0a3729c5a71c716",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c527896a27f2b12500b6b730ce07ab97ccbafff0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c527896a27f2b12500b6b730ce07ab97ccbafff0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d2a7bde48d5c4e4106e9f889e0a3729c5a71c716 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5379) 
   * c527896a27f2b12500b6b730ce07ab97ccbafff0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14d53ae063d5875b5b4b104b4b6005b2f755446e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302) 
   * 3faa1b539faff3a59454cf9710ea69f4dd395e05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] lonelyGhostisdog commented on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
lonelyGhostisdog commented on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670932013


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] lonelyGhostisdog commented on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
lonelyGhostisdog commented on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-671752843


   > ## CI report:
   > * [d2a7bde](https://github.com/apache/flink/commit/d2a7bde48d5c4e4106e9f889e0a3729c5a71c716) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5379)
   > 
   > Bot commands
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "671003019",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "d2a7bde48d5c4e4106e9f889e0a3729c5a71c716",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5379",
       "triggerID" : "d2a7bde48d5c4e4106e9f889e0a3729c5a71c716",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3faa1b539faff3a59454cf9710ea69f4dd395e05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308) 
   * d2a7bde48d5c4e4106e9f889e0a3729c5a71c716 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5379) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-671249958


   Besides, it would be great if you can add the corresponding documentation in this PR. 
   But create a following up JIRA issue is also fine to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "671003019",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3faa1b539faff3a59454cf9710ea69f4dd395e05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * abe0926d30fc18a2b0ba2834ba7ff74c4e669743 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301) 
   * 14d53ae063d5875b5b4b104b4b6005b2f755446e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670817878


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit abe0926d30fc18a2b0ba2834ba7ff74c4e669743 (Sat Aug 08 03:39:18 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] lonelyGhostisdog closed pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
lonelyGhostisdog closed pull request #13090:
URL: https://github.com/apache/flink/pull/13090


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "671003019",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "d2a7bde48d5c4e4106e9f889e0a3729c5a71c716",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5379",
       "triggerID" : "d2a7bde48d5c4e4106e9f889e0a3729c5a71c716",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d2a7bde48d5c4e4106e9f889e0a3729c5a71c716 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5379) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] lonelyGhostisdog commented on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
lonelyGhostisdog commented on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-671003019


   @flinkbot run travis


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3faa1b539faff3a59454cf9710ea69f4dd395e05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] lonelyGhostisdog removed a comment on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
lonelyGhostisdog removed a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-671750025


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "671003019",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "d2a7bde48d5c4e4106e9f889e0a3729c5a71c716",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5379",
       "triggerID" : "d2a7bde48d5c4e4106e9f889e0a3729c5a71c716",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c527896a27f2b12500b6b730ce07ab97ccbafff0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5403",
       "triggerID" : "c527896a27f2b12500b6b730ce07ab97ccbafff0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d2a7bde48d5c4e4106e9f889e0a3729c5a71c716 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5379) 
   * c527896a27f2b12500b6b730ce07ab97ccbafff0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5403) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * abe0926d30fc18a2b0ba2834ba7ff74c4e669743 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301) 
   * 14d53ae063d5875b5b4b104b4b6005b2f755446e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302) 
   * 3faa1b539faff3a59454cf9710ea69f4dd395e05 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "671003019",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3faa1b539faff3a59454cf9710ea69f4dd395e05 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13090:
URL: https://github.com/apache/flink/pull/13090#discussion_r467776390



##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/maxwell/MaxwellJsonDeserializationSchema.java
##########
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.formats.json.maxwell;
+
+import org.apache.flink.api.common.serialization.DeserializationSchema;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.formats.json.JsonRowDataDeserializationSchema;
+import org.apache.flink.formats.json.TimestampFormat;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.data.GenericRowData;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.types.RowKind;
+import org.apache.flink.util.Collector;
+
+import java.io.IOException;
+import java.util.Objects;
+
+import static java.lang.String.format;
+import static org.apache.flink.table.types.utils.TypeConversions.fromLogicalToDataType;
+
+/**
+ * Deserialization schema from Maxwell JSON to Flink Table/SQL internal data structure {@link RowData}.
+ * The deserialization schema knows Maxwell's schema definition and can extract the database data
+ * and convert into {@link RowData} with {@link RowKind}.
+ *
+ * <p>Deserializes a <code>byte[]</code> message as a JSON object and reads
+ * the specified fields.
+ *
+ * <p>Failures during deserialization are forwarded as wrapped IOExceptions.
+ *
+ * @see <a href="http://maxwells-daemon.io/">Maxwell</a>
+ */
+public class MaxwellJsonDeserializationSchema implements DeserializationSchema<RowData> {
+	private static final long serialVersionUID = 1L;
+
+	private static final String OP_INSERT = "insert";
+	private static final String OP_UPDATE = "update";
+	private static final String OP_DELETE = "delete";
+
+	/** The deserializer to deserialize Maxwell JSON data. */
+	private final JsonRowDataDeserializationSchema jsonDeserializer;
+
+	/** TypeInformation of the produced {@link RowData}. **/
+	private final TypeInformation<RowData> resultTypeInfo;
+
+	/** Flag indicating whether to ignore invalid fields/rows (default: throw an exception). */
+	private final boolean ignoreParseErrors;
+
+	/** Number of fields. */
+	private final int fieldCount;
+
+	public MaxwellJsonDeserializationSchema(RowType rowType,
+											TypeInformation<RowData> resultTypeInfo,
+											boolean ignoreParseErrors,
+											TimestampFormat timestampFormatOption) {

Review comment:
       ```suggestion
   	public MaxwellJsonDeserializationSchema(
   			RowType rowType,
   			TypeInformation<RowData> resultTypeInfo,
   			boolean ignoreParseErrors,
   			TimestampFormat timestampFormatOption) {
   ```
   
   Indent.

##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/maxwell/MaxwellJsonDeserializationSchema.java
##########
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.formats.json.maxwell;
+
+import org.apache.flink.api.common.serialization.DeserializationSchema;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.formats.json.JsonRowDataDeserializationSchema;
+import org.apache.flink.formats.json.TimestampFormat;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.data.GenericRowData;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.types.RowKind;
+import org.apache.flink.util.Collector;
+
+import java.io.IOException;
+import java.util.Objects;
+
+import static java.lang.String.format;
+import static org.apache.flink.table.types.utils.TypeConversions.fromLogicalToDataType;
+
+/**
+ * Deserialization schema from Maxwell JSON to Flink Table/SQL internal data structure {@link RowData}.
+ * The deserialization schema knows Maxwell's schema definition and can extract the database data
+ * and convert into {@link RowData} with {@link RowKind}.
+ *
+ * <p>Deserializes a <code>byte[]</code> message as a JSON object and reads
+ * the specified fields.
+ *
+ * <p>Failures during deserialization are forwarded as wrapped IOExceptions.
+ *
+ * @see <a href="http://maxwells-daemon.io/">Maxwell</a>
+ */
+public class MaxwellJsonDeserializationSchema implements DeserializationSchema<RowData> {
+	private static final long serialVersionUID = 1L;
+
+	private static final String OP_INSERT = "insert";
+	private static final String OP_UPDATE = "update";
+	private static final String OP_DELETE = "delete";
+
+	/** The deserializer to deserialize Maxwell JSON data. */
+	private final JsonRowDataDeserializationSchema jsonDeserializer;
+
+	/** TypeInformation of the produced {@link RowData}. **/
+	private final TypeInformation<RowData> resultTypeInfo;
+
+	/** Flag indicating whether to ignore invalid fields/rows (default: throw an exception). */
+	private final boolean ignoreParseErrors;
+
+	/** Number of fields. */
+	private final int fieldCount;
+
+	public MaxwellJsonDeserializationSchema(RowType rowType,
+											TypeInformation<RowData> resultTypeInfo,
+											boolean ignoreParseErrors,
+											TimestampFormat timestampFormatOption) {
+		this.resultTypeInfo = resultTypeInfo;
+		this.ignoreParseErrors = ignoreParseErrors;
+		this.fieldCount = rowType.getFieldCount();
+		this.jsonDeserializer = new JsonRowDataDeserializationSchema(
+			createJsonRowType(fromLogicalToDataType(rowType)),
+			// the result type is never used, so it's fine to pass in Canal's result type
+			resultTypeInfo,
+			false, // ignoreParseErrors already contains the functionality of failOnMissingField
+			ignoreParseErrors,
+			timestampFormatOption);
+	}
+
+	@Override
+	public RowData deserialize(byte[] message) throws IOException {
+		throw new RuntimeException(
+			"Please invoke DeserializationSchema#deserialize(byte[], Collector<RowData>) instead.");
+	}
+
+	@Override
+	public void deserialize(byte[] message, Collector<RowData> out) throws IOException {
+		try {
+			RowData row = jsonDeserializer.deserialize(message);
+			String type = row.getString(2).toString(); // "type" field
+			if (OP_INSERT.equals(type)) {
+				// difference with canal-json is that the "data" section in canal-json contains Array <Row <>>,
+				// and maxwell-json is Row <>
+				// So just take out Row<> in row and collect it

Review comment:
       We don't need to compare with canal-json in the comment. From my point of view, canal-json is a special case in encoding. You can just mention the "data" is the new image of insertion. 

##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/maxwell/MaxwellJsonSerializationSchema.java
##########
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.formats.json.maxwell;
+
+import org.apache.flink.api.common.serialization.SerializationSchema;
+import org.apache.flink.formats.json.JsonRowDataSerializationSchema;
+import org.apache.flink.formats.json.TimestampFormat;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.data.GenericRowData;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.data.StringData;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.types.RowKind;
+
+import java.util.Objects;
+
+import static org.apache.flink.table.types.utils.TypeConversions.fromLogicalToDataType;
+
+/**
+ * Serialization schema from Flink Table/SQL internal data structure {@link RowData} to maxwell-Json.
+ */
+public class MaxwellJsonSerializationSchema implements SerializationSchema<RowData> {
+	private static final long serialVersionUID = 1L;
+
+	private static final StringData OP_INSERT = StringData.fromString("insert");
+	private static final StringData OP_DELETE = StringData.fromString("delete");
+
+	private final JsonRowDataSerializationSchema jsonSerializer;
+
+	/**
+	 * Timestamp format specification which is used to parse timestamp.
+	 */
+	private final TimestampFormat timestampFormat;
+
+	private transient GenericRowData reuse;
+
+	public MaxwellJsonSerializationSchema(RowType rowType, TimestampFormat timestampFormat) {
+		this.jsonSerializer = new JsonRowDataSerializationSchema(
+			createJsonRowType(fromLogicalToDataType(rowType)),
+			timestampFormat);
+		this.timestampFormat = timestampFormat;
+	}
+
+	@Override
+	public void open(InitializationContext context) throws Exception {
+		this.reuse = new GenericRowData(3);
+	}
+
+	@Override
+	public byte[] serialize(RowData element) {
+		reuse.setField(0, element);
+		reuse.setField(1, null);
+		reuse.setField(2, rowKind2String(element.getRowKind()));
+		return jsonSerializer.serialize(reuse);
+	}
+
+	private StringData rowKind2String(RowKind rowKind) {
+		switch (rowKind) {
+			case INSERT:
+			case UPDATE_AFTER:
+				return OP_INSERT;
+			case UPDATE_BEFORE:
+			case DELETE:
+				return OP_DELETE;
+			default:
+				throw new UnsupportedOperationException("Unsupported operation '" + rowKind + "' for row kind.");
+		}
+	}
+
+	@Override
+	public boolean equals(Object o) {
+		if (this == o) {
+			return true;
+		}
+		if (o == null || getClass() != o.getClass()) {
+			return false;
+		}
+		MaxwellJsonSerializationSchema that = (MaxwellJsonSerializationSchema) o;
+		return Objects.equals(jsonSerializer, that.jsonSerializer) &&
+			timestampFormat == that.timestampFormat;
+	}
+
+	@Override
+	public int hashCode() {
+		return Objects.hash(jsonSerializer, timestampFormat);
+	}
+
+	private RowType createJsonRowType(DataType databaseSchema) {
+		DataType payload = DataTypes.ROW(
+			DataTypes.FIELD("data", databaseSchema),
+			DataTypes.FIELD("old", databaseSchema),

Review comment:
       From the `maxwell-data.txt`, it seems that insert and delete doesn't produce `old` field. Shall we remove this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * abe0926d30fc18a2b0ba2834ba7ff74c4e669743 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301) 
   * 14d53ae063d5875b5b4b104b4b6005b2f755446e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * abe0926d30fc18a2b0ba2834ba7ff74c4e669743 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] lonelyGhostisdog commented on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
lonelyGhostisdog commented on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-671757623


   > ## CI report:
   > * [d2a7bde](https://github.com/apache/flink/commit/d2a7bde48d5c4e4106e9f889e0a3729c5a71c716) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5379)
   > 
   > Bot commands
   
   @flinkbot  run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18844][json][maxwell] Support maxwell-json format to read Maxwell changelogs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305",
       "triggerID" : "670932013",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308",
       "triggerID" : "671003019",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "d2a7bde48d5c4e4106e9f889e0a3729c5a71c716",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d2a7bde48d5c4e4106e9f889e0a3729c5a71c716",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3faa1b539faff3a59454cf9710ea69f4dd395e05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5305) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5308) 
   * d2a7bde48d5c4e4106e9f889e0a3729c5a71c716 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302",
       "triggerID" : "14d53ae063d5875b5b4b104b4b6005b2f755446e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3faa1b539faff3a59454cf9710ea69f4dd395e05",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * abe0926d30fc18a2b0ba2834ba7ff74c4e669743 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5301) 
   * 14d53ae063d5875b5b4b104b4b6005b2f755446e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5302) 
   * 3faa1b539faff3a59454cf9710ea69f4dd395e05 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13090: [FLINK-18822] [umbrella] Improve and complete Change Data Capture formats

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13090:
URL: https://github.com/apache/flink/pull/13090#issuecomment-670818966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "abe0926d30fc18a2b0ba2834ba7ff74c4e669743",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * abe0926d30fc18a2b0ba2834ba7ff74c4e669743 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org