You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2020/02/13 03:16:00 UTC
Review Request 72126: Added a test to ensure agents cannot be
reactivated while DRAINING.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72126/
-----------------------------------------------------------
Review request for mesos, Greg Mann and Joseph Wu.
Bugs: MESOS-10096
https://issues.apache.org/jira/browse/MESOS-10096
Repository: mesos
Description
-------
Added a test to ensure agents cannot be reactivated while DRAINING.
Diffs
-----
src/tests/master_draining_tests.cpp f1a00dfdb47b3cc095f7da9c9d3b8fa5933f8846
Diff: https://reviews.apache.org/r/72126/diff/1/
Testing
-------
Ran in repetition.
Thanks,
Benjamin Mahler
Re: Review Request 72126: Added a test to ensure agents cannot be
reactivated while DRAINING.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72126/#review219660
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/master_draining_tests.cpp
Lines 1109 (patched)
<https://reviews.apache.org/r/72126/#comment307869>
This agent is reachable right? It just doesn't have a cooperative executor.
- Joseph Wu
On Feb. 12, 2020, 7:16 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72126/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2020, 7:16 p.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-10096
> https://issues.apache.org/jira/browse/MESOS-10096
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to ensure agents cannot be reactivated while DRAINING.
>
>
> Diffs
> -----
>
> src/tests/master_draining_tests.cpp f1a00dfdb47b3cc095f7da9c9d3b8fa5933f8846
>
>
> Diff: https://reviews.apache.org/r/72126/diff/1/
>
>
> Testing
> -------
>
> Ran in repetition.
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 72126: Added a test to ensure agents cannot be
reactivated while DRAINING.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72126/#review219568
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72116, 72124, 72125, 72126]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On Feb. 13, 2020, 3:16 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72126/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2020, 3:16 a.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-10096
> https://issues.apache.org/jira/browse/MESOS-10096
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to ensure agents cannot be reactivated while DRAINING.
>
>
> Diffs
> -----
>
> src/tests/master_draining_tests.cpp f1a00dfdb47b3cc095f7da9c9d3b8fa5933f8846
>
>
> Diff: https://reviews.apache.org/r/72126/diff/1/
>
>
> Testing
> -------
>
> Ran in repetition.
>
>
> Thanks,
>
> Benjamin Mahler
>
>