You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/21 09:57:27 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #5796: Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment.
GabrielBrascher opened a new pull request #5796:
URL: https://github.com/apache/cloudstack/pull/5796
### Description
In the UI, when selecting a service offering that has a root disk enforced, stills show the root disk size of the template (or the custom size gave by the user). This PR fixes this issue, that thas been reported in #5777.
Fixes: #5777
Now the UI dynamically changes the root disk size according to the following variables, following the priority order:
1. Service offering size (highest priority)
2. Custom size set by the user
3. Template size
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
#### 1. Choose template, set custom rootdisk size to 123GB
#### 2. Choose an offering with root disk size set to 30
#### 3. Change to another offering, e.g. with 50G
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
1. Build UI (npm run serve)
2. Choose a template -- root disk size matches with the template
3. Set custom root disk size to 123GB -- UI updated with the new root disk size
4. Choose an offering with root disk size set to 30 -- UI changes to the service offering root disk size
5. Change to another offering, e.g. with 50G -- again, the UI updates
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5796: Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5796:
URL: https://github.com/apache/cloudstack/pull/5796#issuecomment-998963623
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5796 (SL-JID-925)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5796: Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #5796:
URL: https://github.com/apache/cloudstack/pull/5796#discussion_r773141610
##########
File path: ui/src/views/compute/DeployVM.vue
##########
@@ -1133,6 +1133,10 @@ export default {
this.vm.disksizetotalgb = this.diskSize
}
+ if (this.serviceOffering.rootdisksize) {
+ this.vm.disksizetotalgb = this.serviceOffering.rootdisksize
+ }
Review comment:
Your suggestion looks better indeed, I will add it into the PR.
Thanks for the review, @sureshanaparti.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5796: Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5796:
URL: https://github.com/apache/cloudstack/pull/5796#issuecomment-998959650
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #5796: Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment.
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged pull request #5796:
URL: https://github.com/apache/cloudstack/pull/5796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5796: Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5796:
URL: https://github.com/apache/cloudstack/pull/5796#issuecomment-998652802
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5796 (SL-JID-922)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5796: Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment.
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5796:
URL: https://github.com/apache/cloudstack/pull/5796#issuecomment-998698686
@GabrielBrascher this works but in my test once I select compute offering with root disk size the Override Root Disk Size option becomes disabled and it remains disabled even after I switch to different offering. Though this isn't particularly related to the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5796: Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5796:
URL: https://github.com/apache/cloudstack/pull/5796#issuecomment-998959120
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5796: Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5796:
URL: https://github.com/apache/cloudstack/pull/5796#discussion_r773084970
##########
File path: ui/src/views/compute/DeployVM.vue
##########
@@ -1133,6 +1133,10 @@ export default {
this.vm.disksizetotalgb = this.diskSize
}
+ if (this.serviceOffering.rootdisksize) {
+ this.vm.disksizetotalgb = this.serviceOffering.rootdisksize
+ }
Review comment:
@GabrielBrascher just a suggestion
```
if (this.serviceOffering.rootdisksize) {
this.vm.disksizetotalgb = this.serviceOffering.rootdisksize
} else if (this.diskSize) {
this.vm.disksizetotalgb = this.diskSize
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5796: Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5796:
URL: https://github.com/apache/cloudstack/pull/5796#issuecomment-998648022
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5796: Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment.
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5796:
URL: https://github.com/apache/cloudstack/pull/5796#issuecomment-998647481
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org