You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/30 21:10:45 UTC

[GitHub] [maven-surefire] andpab commented on pull request #565: add jdk 19

andpab commented on PR #565:
URL: https://github.com/apache/maven-surefire/pull/565#issuecomment-1368091463

   I rebased this branch to master locally and ran the ITs. Most of them are successful except for 6 JPMS-related ITs:
   
   - MultiModuleProjectWithJPMSIT
   - Surefire1570ModularFailsafeIT
   - Surefire1712ExtractedModulenameWithoutASMIT
   - Surefire1733JUnitIT
   - Surefire1733TestngIT
   - Surefire1993JpmsProvidingModulesIT
   
   They fail because the modules are not detected.
   
   Changing the `maven.compiler.release` property from 19 to 18 in the test projects made the tests succeed. Looked like Surefire having a problem with JDK19-level bytecode for projects using JPMS, so I checked the dependency tree. It has ASM in version 9.2, coming in transitively via plexus-java-1.1.1. ASM 9.2 does not support JDK19 byte code.
   
   I set ASM to 9.4 in the dependencyManagement section of the main pom.xml and the ITs were successful.
   
   I've created a JIRA issue for it which also documents the two options for fixing the issue:  SUREFIRE-2139


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org