You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/16 03:27:16 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #718: FIX - customize theme
utchoang opened a new pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718
Fixes #712 #713
- [x] Customize link hover color
- [x] Customize loading color
- [ ] Customize background color
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696556549
@utchoang I saw that only the navigation colour can be set. I would expect the main pane to be matching. Does that make sense? Or should it also be a separate colour?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696317520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697174576
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693283161
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697148754
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693291859
@rhtyd Do we need to add a light / dark mode to the red border area (image)? Because this will make CSS editing pretty much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-695976058
LGTM, need bit of testing
@davidjumani @andrijapanicsb can you review/test? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696559221
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696678564
@utchoang can you send a doc PR to https://github.com/apache/cloudstack-documentation/blob/master/source/installguide/primate.rst#basic-customization-in-cloudstack-primate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693936388
Customize navigation background color and text color
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696556549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694708920
Customize navigation color
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697152756
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3501)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696677919
Thanks @utchoang @DaanHoogland lgtm, but I need to do one round of test with a real deb/rpm based package. I'll merge it after that (today/tomorrow).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696559221
@DaanHoogland Regarding the adjustment of the main page, it takes quite a lot of changes (CSS, style). Can I do it if it's absolutely necessary? @rhtyd thought?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang removed a comment on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693299441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697151776
Tested, LGTM
Verified left nav bar colour for default view:
Project view is still dark-er though:
@utchoang would it be possible to define a custom background colour for the navigation bar on left when we're in a project view (i.e. selected a project)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang edited a comment on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693299441
@rhtyd Does the dark mode of the switch to the project affect the custom theme with config.json? For example background color?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694713760
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697173747
* For select project
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693299441
@rhtyd Does the dark mode of the switch to the project affect the custom theme with config.json? For example background color?
=
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696322380
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3497)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696343996
@rhtyd do we (a.k.a @utchoang) update the customize.md before merging?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696599663
@DaanHoogland Yes. I've updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696316825
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693148793
- Customize link hover color
- Customize loading color
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696317520
@DaanHoogland a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang removed a comment on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693936388
Customize navigation background color and text color
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694712862
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3483)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697174598
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696058213
cc @DaanHoogland
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697148486
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694717686
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3484)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#discussion_r493215529
##########
File path: src/views/AutogenView.vue
##########
@@ -653,16 +653,9 @@ export default {
return
}
- if ([401].includes(error.response.status)) {
Review comment:
@rhtyd I don't have changed it. Maybe it's because I haven't merged with the latest master yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697178510
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3502)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696677919
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693282324
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#discussion_r493213313
##########
File path: src/views/AutogenView.vue
##########
@@ -653,16 +653,9 @@ export default {
return
}
- if ([401].includes(error.response.status)) {
Review comment:
@utchoang why not dispatch logout on 401/unauthorise error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696316825
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#discussion_r493213585
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -1749,11 +1749,11 @@ export default {
},
fetchTemplateNics (template) {
var nics = []
- if (template && template.deployasisdetails && Object.keys(template.deployasisdetails).length > 0) {
Review comment:
@utchoang why is this part of the PR change?
##########
File path: src/views/iam/DomainView.vue
##########
@@ -181,14 +181,7 @@ export default {
duration: 0
})
- if ([401].includes(error.response.status)) {
Review comment:
@utchoang same as above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693287727
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3479)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696066231
@utchoang code LGTM, can you update the https://github.com/apache/cloudstack-primate/blob/master/docs/customize.md in sync with your FR and the doc https://github.com/apache/cloudstack-documentation/blob/master/source/installguide/primate.rst (you'll need to send a separate PR to the apache/cloudstack-documentation repo). Thanks.
I'll need second pair of testing from @DaanHoogland or @davidjumani thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697178296
Thanks @utchoang I'll review, test and merge shortly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697175875
@rhtyd I've updated customize.md on this PR and a document on https://github.com/apache/cloudstack-documentation/pull/159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694709147
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694713172
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697174341
Thanks @utchoang pl update the customize.md and send a doc PR to the documentation repo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696591312
are you updating `customize.md` in this PR, @utchoang ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694708985
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696571307
@utchoang It was just an observation with regards to the issue #714 I do consider this a feature (not broderline-) so I do not regard this part of 1.0 ga! I think we should have a full theming/cusitmization issue for 1.1. I think we should merge this and call it a release. I assure you, I'll keep coming up with issues if we don't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-695976058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org