You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by mi...@apache.org on 2018/02/16 12:55:49 UTC
svn commit: r1824460 - /httpd/httpd/trunk/modules/proxy/proxy_util.c
Author: minfrin
Date: Fri Feb 16 12:55:49 2018
New Revision: 1824460
URL: http://svn.apache.org/viewvc?rev=1824460&view=rev
Log:
Tone down the message that worker hostname is too long noting it only
affects legacy modules not yet using hostname_ex.
Modified:
httpd/httpd/trunk/modules/proxy/proxy_util.c
Modified: httpd/httpd/trunk/modules/proxy/proxy_util.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/proxy_util.c?rev=1824460&r1=1824459&r2=1824460&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)
+++ httpd/httpd/trunk/modules/proxy/proxy_util.c Fri Feb 16 12:55:49 2018
@@ -1727,13 +1727,14 @@ PROXY_DECLARE(char *) ap_proxy_define_wo
ap_log_error(APLOG_MARK, APLOG_ERR, 0, ap_server_conf, APLOGNO(010117)
"Alert! worker scheme (%s) too long; truncated to: %s", uri.scheme, wshared->scheme);
}
- if (PROXY_STRNCPY(wshared->hostname, uri.hostname) != APR_SUCCESS) {
- ap_log_error(APLOG_MARK, APLOG_ERR, 0, ap_server_conf, APLOGNO(010118)
- "Alert! worker hostname (%s) too long; truncated to: %s", uri.hostname, wshared->hostname);
- }
if (PROXY_STRNCPY(wshared->hostname_ex, uri.hostname) != APR_SUCCESS) {
return apr_psprintf(p, "worker hostname (%s) too long", uri.hostname);
}
+ if (PROXY_STRNCPY(wshared->hostname, uri.hostname) != APR_SUCCESS) {
+ ap_log_error(APLOG_MARK, APLOG_NOTICE, 0, ap_server_conf, APLOGNO(010118)
+ "worker hostname (%s) too long; truncated for legacy modules that do not use "
+ "proxy_worker_shared->hostname_ex: %s", uri.hostname, wshared->hostname);
+ }
wshared->flush_packets = flush_off;
wshared->flush_wait = PROXY_FLUSH_WAIT;
wshared->is_address_reusable = 1;
Re: svn commit: r1824460 - /httpd/httpd/trunk/modules/proxy/proxy_util.c
Posted by Yann Ylavic <yl...@gmail.com>.
On Fri, Feb 16, 2018 at 1:55 PM, <mi...@apache.org> wrote:
> Author: minfrin
> Date: Fri Feb 16 12:55:49 2018
> New Revision: 1824460
>
> URL: http://svn.apache.org/viewvc?rev=1824460&view=rev
> Log:
> Tone down the message that worker hostname is too long noting it only
> affects legacy modules not yet using hostname_ex.
NOTICE is not really a "Tone down" (always logged), INFO maybe?
Regards,
Yann.