You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/02/17 11:49:28 UTC
[GitHub] [echarts] Nurech opened a new issue #16532: [Bug] Exported custom JSON theme file can not be imported
Nurech opened a new issue #16532:
URL: https://github.com/apache/echarts/issues/16532
### Version
5.3.0
### Link to Minimal Reproduction
https://echarts.apache.org/en/theme-builder.html
### Steps to Reproduce
1. Take any theme.
2. Modify it a bit.
3. Save as json file.
4. Try to import.
5. It fails. _"Please use the exported JSON configuration files from our site instead of downloaded theme file. "_
### Current Behavior
Does not let import theme JSON file.
### Expected Behavior
Would be nice to import it for editing.
### Environment
_No response_
### Any additional comments?
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #16532: [Bug] Exported custom JSON theme file can not be imported
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #16532:
URL: https://github.com/apache/echarts/issues/16532#issuecomment-1043959504
You may refer to the [source code](https://github.com/apache/echarts-theme-builder/blob/master/app/scripts/main_en.js) and check if you modified or deleted some fields required by ECharts theme builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #16532: [Bug] Exported custom JSON theme file can not be imported
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #16532:
URL: https://github.com/apache/echarts/issues/16532#issuecomment-1044109879
If so, I guess you are using **_Download_** rather than **_Export_**. To be clear, you will get a JSON/JS file via the **_Download_** button, it can be directly used in ECharts but it's **NOT** available for ECharts theme builder. Only the files generated by **_Export_** are acceptable for the theme builder. You should click the **_Export_** button to get the configuration file and then upload the modified file via **_Import_** button to preview, adjust, or download your customized theme(also via **_Download_**).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Nurech closed issue #16532: [Bug] Exported custom JSON theme file can not be imported
Posted by GitBox <gi...@apache.org>.
Nurech closed issue #16532:
URL: https://github.com/apache/echarts/issues/16532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Nurech commented on issue #16532: [Bug] Exported custom JSON theme file can not be imported
Posted by GitBox <gi...@apache.org>.
Nurech commented on issue #16532:
URL: https://github.com/apache/echarts/issues/16532#issuecomment-1042931389
> What did you modify in this file? Is there any error from the console?
Well I edited the file quite a bit and when I went to modify it I got the error message. When trying to figure out if my theme was malformed I tried to validate one of your default themes by downloading a random theme from echarts selection and trying to import it (it fails). This leads me to believe that problem is on echart side and no one can upload/import any theme files. Must be some kind of frontend validator for the JSON as I don't see any errors in the console nor any requests going out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Nurech edited a comment on issue #16532: [Bug] Exported custom JSON theme file can not be imported
Posted by GitBox <gi...@apache.org>.
Nurech edited a comment on issue #16532:
URL: https://github.com/apache/echarts/issues/16532#issuecomment-1042931389
> What did you modify in this file? Is there any error from the console?
Well I edited the file quite a bit and when I went to modify it I got the error message. When trying to figure out if my theme was malformed I tried to validate one of echarts default themes by downloading a random theme from echarts selection and without even editing it importing fails. This leads me to believe that problem is on echart side and no one can upload/import any theme files. Must be some kind of frontend validator for the JSON as I don't see any errors in the console nor any requests going out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #16532: [Bug] Exported custom JSON theme file can not be imported
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #16532:
URL: https://github.com/apache/echarts/issues/16532#issuecomment-1044134166
Thanks. It's not perfect currently but I believe we will improve and enhance the theme tool in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Nurech commented on issue #16532: [Bug] Exported custom JSON theme file can not be imported
Posted by GitBox <gi...@apache.org>.
Nurech commented on issue #16532:
URL: https://github.com/apache/echarts/issues/16532#issuecomment-1044067576
> You may refer to the [source code](https://github.com/apache/echarts-theme-builder/blob/master/app/scripts/main_en.js) and check if you modified or deleted some fields required by ECharts theme builder.
I am literally downloading an **unmodified** theme from echarts theme builder and then trying to upload it back to itself - it errors. Weird that it's not backwards compatible - if it can't accept an valid theme from source it surely can't accept any themes (changed or not changed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #16532: [Bug] Exported custom JSON theme file can not be imported
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #16532:
URL: https://github.com/apache/echarts/issues/16532#issuecomment-1042871219
What did you modify in this file? Is there any error from the console?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Nurech commented on issue #16532: [Bug] Exported custom JSON theme file can not be imported
Posted by GitBox <gi...@apache.org>.
Nurech commented on issue #16532:
URL: https://github.com/apache/echarts/issues/16532#issuecomment-1044121483
> If so, I guess you are using **_Download_** rather than **_Export_**. To be clear, you will get a JSON/JS file via the **_Download_** button, it can be directly used in ECharts but it's **NOT** available for ECharts theme builder. Only the files generated by **_Export_** are acceptable for the theme builder. You should click the **_Export_** button to get the configuration file and then upload the modified file via **_Import_** button to preview, adjust, or download your customized theme(also via **_Download_**).
You are right, I was "Downloading" the JSON file for echarts and trying to import it back!
I was not using "Export" function. Heh... should have read the help section for this. _The exported JSON file can be used only in this tool, but not in ECharts directly._ Too bad though, once you download the JSON and you forget to export secondary copy you're out of luck. Start from scratch or try to copy-paste-salvage what you have. But anyway, I'm not complaining - this is already pretty awesome that they even have theme tooling!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org