You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/15 18:40:12 UTC

[GitHub] [arrow] zeroshade opened a new pull request, #13885: ARROW-17410: [JS][Integration] Downgrade zlib for integration

zeroshade opened a new pull request, #13885:
URL: https://github.com/apache/arrow/pull/13885

   Downgrading to `zlib=1.2.11` fixes the existing issue as reported in https://github.com/madler/zlib/issues/613 until the patch is released.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm commented on a diff in pull request #13885: ARROW-17410: [JS][Integration] Downgrade zlib for integration

Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13885:
URL: https://github.com/apache/arrow/pull/13885#discussion_r946024742


##########
ci/docker/conda-integration.dockerfile:
##########
@@ -35,7 +35,8 @@ RUN mamba install -q -y \
         maven=${maven} \
         nodejs=${node} \
         yarn \
-        openjdk=${jdk} && \
+        openjdk=${jdk} \
+        zlib=1.2.11 && \

Review Comment:
   nit: include the JIRA in a comment so it's clear why we have this pin here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm commented on pull request #13885: ARROW-17410: [JS][Integration] Downgrade zlib for integration

Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13885:
URL: https://github.com/apache/arrow/pull/13885#issuecomment-1215640723

   looks like that fixed it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #13885: ARROW-17410: [JS][Integration] Downgrade zlib for integration

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13885:
URL: https://github.com/apache/arrow/pull/13885#issuecomment-1215907543

   Benchmark runs are scheduled for baseline = a270afc946398a0279b1971a315858d8b5f07e2d and contender = 3a59bc0209ed28415cbd824d1d63662e8ab5dc64. 3a59bc0209ed28415cbd824d1d63662e8ab5dc64 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4883232e8f4648059c7d939f52c00885...ce502caa40164d60b7c24709e3958f0e/)
   [Failed :arrow_down:0.17% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/bb22d1f7d8df40598f37e2760bdec4be...8b6e03ccb2df44b984d04c588e0a4180/)
   [Failed :arrow_down:0.55% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d1a9add1ab8e4e15b7ed87ef902942f2...05ec74bb8b01464ab4f2949f2606a3dd/)
   [Finished :arrow_down:0.32% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5c3ba37f761f4ac89555bbcc84d8a209...7a4edf83560e453db7e7a60254f958bd/)
   Buildkite builds:
   [Finished] [`3a59bc02` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1309)
   [Failed] [`3a59bc02` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1325)
   [Failed] [`3a59bc02` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1307)
   [Finished] [`3a59bc02` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1324)
   [Finished] [`a270afc9` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1308)
   [Failed] [`a270afc9` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1324)
   [Failed] [`a270afc9` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1306)
   [Finished] [`a270afc9` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1323)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zeroshade commented on a diff in pull request #13885: ARROW-17410: [JS][Integration] Downgrade zlib for integration

Posted by GitBox <gi...@apache.org>.
zeroshade commented on code in PR #13885:
URL: https://github.com/apache/arrow/pull/13885#discussion_r946027110


##########
ci/docker/conda-integration.dockerfile:
##########
@@ -35,7 +35,8 @@ RUN mamba install -q -y \
         maven=${maven} \
         nodejs=${node} \
         yarn \
-        openjdk=${jdk} && \
+        openjdk=${jdk} \
+        zlib=1.2.11 && \

Review Comment:
   comment is added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #13885: ARROW-17410: [JS][Integration] Downgrade zlib for integration

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13885:
URL: https://github.com/apache/arrow/pull/13885#issuecomment-1215907793

   ['Python', 'R'] benchmarks have high level of regressions.
   [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d1a9add1ab8e4e15b7ed87ef902942f2...05ec74bb8b01464ab4f2949f2606a3dd/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #13885: ARROW-17410: [JS][Integration] Downgrade zlib for integration

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13885:
URL: https://github.com/apache/arrow/pull/13885#issuecomment-1215597974

   https://issues.apache.org/jira/browse/ARROW-17410


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zeroshade commented on a diff in pull request #13885: ARROW-17410: [JS][Integration] Downgrade zlib for integration

Posted by GitBox <gi...@apache.org>.
zeroshade commented on code in PR #13885:
URL: https://github.com/apache/arrow/pull/13885#discussion_r946024998


##########
ci/docker/conda-integration.dockerfile:
##########
@@ -35,7 +35,8 @@ RUN mamba install -q -y \
         maven=${maven} \
         nodejs=${node} \
         yarn \
-        openjdk=${jdk} && \
+        openjdk=${jdk} \
+        zlib=1.2.11 && \

Review Comment:
   good point! Will do



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zeroshade merged pull request #13885: ARROW-17410: [JS][Integration] Downgrade zlib for integration

Posted by GitBox <gi...@apache.org>.
zeroshade merged PR #13885:
URL: https://github.com/apache/arrow/pull/13885


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org