You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by vi...@apache.org on 2018/07/30 17:36:45 UTC

hive git commit: HIVE-20168 : ReduceSinkOperator Logging Hidden (Bharathkrishna Guruvayoor Murali reviewed by Vihang Karajgaonkar)

Repository: hive
Updated Branches:
  refs/heads/master 350445d29 -> 1c8449cce


HIVE-20168 : ReduceSinkOperator Logging Hidden (Bharathkrishna Guruvayoor Murali reviewed by Vihang Karajgaonkar)


Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/1c8449cc
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/1c8449cc
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/1c8449cc

Branch: refs/heads/master
Commit: 1c8449cce2a961c6ca6ce38bef0d770f34221d4d
Parents: 350445d
Author: Bharathkrishna Guruvayoor Murali <bh...@cloudera.com>
Authored: Mon Jul 30 10:14:26 2018 -0700
Committer: Vihang Karajgaonkar <vi...@cloudera.com>
Committed: Mon Jul 30 10:14:26 2018 -0700

----------------------------------------------------------------------
 .../hadoop/hive/ql/exec/ReduceSinkOperator.java   | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hive/blob/1c8449cc/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java b/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java
index caaf543..a2a9c84 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java
@@ -500,15 +500,13 @@ public class ReduceSinkOperator extends TerminalOperator<ReduceSinkDesc>
     if (null != out) {
       numRows++;
       runTimeNumRows++;
-      if (LOG.isTraceEnabled()) {
-        if (numRows == cntr) {
-          cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows;
-          if (cntr < 0 || numRows < 0) {
-            cntr = 0;
-            numRows = 1;
-          }
-          LOG.info(toString() + ": records written - " + numRows);
+      if (numRows == cntr) {
+        cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows;
+        if (cntr < 0 || numRows < 0) {
+          cntr = 0;
+          numRows = 1;
         }
+        LOG.info("{}: records written - {}", this, numRows);
       }
       out.collect(keyWritable, valueWritable);
     }
@@ -536,9 +534,7 @@ public class ReduceSinkOperator extends TerminalOperator<ReduceSinkDesc>
     out = null;
     random = null;
     reducerHash = null;
-    if (LOG.isTraceEnabled()) {
-      LOG.info(toString() + ": records written - " + numRows);
-    }
+    LOG.info("{}: Total records written - {}. abort - {}", this, numRows, abort);
   }
 
   /**