You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by liucyu <gi...@git.apache.org> on 2017/08/31 03:32:30 UTC

[GitHub] incubator-rocketmq pull request #161: ������

GitHub user liucyu opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/161

    注释

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liucyu/incubator-rocketmq master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #161
    
----
commit 58eeddba94878f06ff3cc0dcecdced6a2c35d3dd
Author: driver.liu <dr...@pkfare.com>
Date:   2017-04-13T03:35:21Z

    注释

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #161: ������

Posted by vsair <gi...@git.apache.org>.
Github user vsair commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/161
  
    Thanks for your contribution, but please read the contributor's guide first. Then, you would,
    
    1. Create an jira issue, and rename the pr's title and description.
    2. Chinese is not allowed in code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #161: ������

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-rocketmq/pull/161


---

[GitHub] incubator-rocketmq issue #161: ������

Posted by lindzh <gi...@git.apache.org>.
Github user lindzh commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/161
  
    As RocketMQ is widely use all over the world,I think there is no need to add chinese comment.I suggest add a blog for source code reading.


---

[GitHub] incubator-rocketmq issue #161: ������

Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/161
  
    @liucyu If no update for this PR, we will close it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---