You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/04 07:33:47 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request #815: ORC-909: Remove commons-io v2.1 dependency
dongjoon-hyun opened a new pull request #815:
URL: https://github.com/apache/orc/pull/815
### What changes were proposed in this pull request?
This PR aims to remove `commons-io` v2.1 dependency.
### Why are the changes needed?
This is a hidden dependency due to a single function `IOUtils.skipFully`. We had better cut this.
```
$ git grep org.apache.commons.io
core/src/java/org/apache/orc/impl/RunLengthByteReader.java:import org.apache.commons.io.IOUtils;
core/src/java/org/apache/orc/impl/SerializationUtils.java:import org.apache.commons.io.IOUtils;
```
### How was this patch tested?
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #815: ORC-909: Remove commons-io v2.1 dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #815:
URL: https://github.com/apache/orc/pull/815#discussion_r682365158
##########
File path: java/core/src/java/org/apache/orc/impl/IOUtils.java
##########
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.orc.impl;
+
+import java.io.EOFException;
+import java.io.IOException;
+import java.io.InputStream;
+
+/**
+ * This is copied from commons-io project to cut the dependency
+ * from old Hadoop.
Review comment:
- https://github.com/apache/commons-io/blob/master/src/main/java/org/apache/commons/io/IOUtils.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #815: ORC-909: Remove commons-io v2.1 dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #815:
URL: https://github.com/apache/orc/pull/815#issuecomment-892492920
Thank you so much, @pgaref !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #815: ORC-909: Remove commons-io v2.1 dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #815:
URL: https://github.com/apache/orc/pull/815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #815: ORC-909: Remove commons-io v2.1 dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #815:
URL: https://github.com/apache/orc/pull/815#issuecomment-892437761
cc @pgaref and @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org