[GitHub] [ozone] siddhantsangwan commented on a diff in pull request #4453: HDDS-8230. Let ReplicationManager decide the timeout for commands in Datanodes

["siddhantsangwan (via GitHub)" <gi...@apache.org>]

siddhantsangwan commented on code in PR #4453:
URL: https://github.com/apache/ozone/pull/4453#discussion_r1145706405


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -627,21 +614,20 @@ public void sendDatanodeCommand(SCMCommand<?> command,
    * @param target The datanode which will receive the command.
    * @param scmDeadlineEpochMs The epoch time in ms, after which the command
    *                           will be discarded from the SCMPendingOps table.
-   * @param datanodeDeadlineEpochMs The epoch time in ms, after which the
-   *                                command will be discarded on the datanode if
-   *                                it has not been processed.
    * @throws NotLeaderException
    */
   public void sendDatanodeCommand(SCMCommand<?> command,
       ContainerInfo containerInfo, DatanodeDetails target,
-      long scmDeadlineEpochMs, long datanodeDeadlineEpochMs)
+      long scmDeadlineEpochMs)
       throws NotLeaderException {
+    long datanodeDeadline =
+        scmDeadlineEpochMs - rmConf.getDatanodeTimeoutOffset();

Review Comment:
   We could have a weird edge case where `datanodeDeadline` is negative. Let's have some sort of a run time validation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org