You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Girish Shilamkar <gi...@clogeny.com> on 2013/05/22 12:17:39 UTC

Review Request: CLOUDSTACK-2577: Fix exception handling for listPortForwarding API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11328/
-----------------------------------------------------------

Review request for cloudstack and Prasanna Santhanam.


Description
-------

listPortForwarding API returns an exception if the PF is deleted.
    Changed testcases to handle this exception.


This addresses bug CLOUDSTACK-2577.


Diffs
-----

  test/integration/smoke/test_network.py 4a7bb44 

Diff: https://reviews.apache.org/r/11328/diff/


Testing
-------


Thanks,

Girish Shilamkar


Re: Review Request: CLOUDSTACK-2577: Fix exception handling for listPortForwarding API

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11328/#review20891
-----------------------------------------------------------


Commit 44a81f0b6f2d4305d8e92058abb88c1a6334d814 in branch refs/heads/master from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=44a81f0 ]

CLOUDSTACK-2577: Fix exception handling for listPortForwarding API

listPortForwarding API returns an exception if the PF is deleted.
Changed testcases to handle this exception.

Signed-off-by: Girish Shilamkar <gi...@clogeny.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On May 22, 2013, 10:17 a.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11328/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 10:17 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> -------
> 
> listPortForwarding API returns an exception if the PF is deleted.
>     Changed testcases to handle this exception.
> 
> 
> This addresses bug CLOUDSTACK-2577.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_network.py 4a7bb44 
> 
> Diff: https://reviews.apache.org/r/11328/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>


Re: Review Request: CLOUDSTACK-2577: Fix exception handling for listPortForwarding API

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11328/#review20892
-----------------------------------------------------------

Ship it!


Thanks for the quick turnaround. Keep an eye on the next run to see the success of the test
http://jenkins.buildacloud.org/job/test-smoke-matrix/

44a81f0

- Prasanna Santhanam


On May 22, 2013, 10:17 a.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11328/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 10:17 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> -------
> 
> listPortForwarding API returns an exception if the PF is deleted.
>     Changed testcases to handle this exception.
> 
> 
> This addresses bug CLOUDSTACK-2577.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_network.py 4a7bb44 
> 
> Diff: https://reviews.apache.org/r/11328/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>