You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/09/30 21:26:32 UTC
[GitHub] [cordova-ios] dpogue opened a new pull request #1154: Swift Package Manager support for CordovaLib
dpogue opened a new pull request #1154:
URL: https://github.com/apache/cordova-ios/pull/1154
### Platforms affected
iOS
### Motivation and Context
This adds a `Package.swift` file to allow installing the CordovaLib library through Swift Package Manager.
This also cleans up our Cocoapods spec file to remove the need to explicitly list each header.
### Description
Swift Package Manager requires all the public headers to be in an `include` folder, so all the headers from `Classes/Public` were moved to `include/Cordova`.
Also got rid of the precompiled header because SwiftPM doesn't know how to do that, and we were only precompiling Foundation and UIKit.
Xcode 13 also adds a new warning when framework headers are used with relative imports `"myfile.h"` rather than framework imports `<myfile.h>`. I've cleaned up the imports for all the public headers. (Note: some of the plugins use private headers, which must retain the relative import syntax)
### Testing
* Tested creating a new Swift project in Xcode, adding CordovaLib using SwiftPM and compiling successfully
* Tested creating a new Objective C project in Xcode, adding CordovaLib using Cocoapods as a dynamic library and compiling successfully
* Tested creating a new Objective C project in Xcode, adding CordovaLib using Cocoapods as a static library and compiling successfully
* Existing test suite passes
### Checklist
- [x] I've run the tests to see all new and existing tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue merged pull request #1154: Swift Package Manager support for CordovaLib
Posted by GitBox <gi...@apache.org>.
dpogue merged pull request #1154:
URL: https://github.com/apache/cordova-ios/pull/1154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter commented on pull request #1154: Swift Package Manager support for CordovaLib
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1154:
URL: https://github.com/apache/cordova-ios/pull/1154#issuecomment-932028648
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1154](https://codecov.io/gh/apache/cordova-ios/pull/1154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc931bf) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4c8136345ae9622646ee7e4eb60ba2b37ad44fbe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c81363) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/1154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1154 +/- ##
=======================================
Coverage 74.86% 74.86%
=======================================
Files 13 13
Lines 1723 1723
=======================================
Hits 1290 1290
Misses 433 433
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4c81363...fc931bf](https://codecov.io/gh/apache/cordova-ios/pull/1154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #1154: Swift Package Manager support for CordovaLib
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1154:
URL: https://github.com/apache/cordova-ios/pull/1154#issuecomment-932028648
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1154](https://codecov.io/gh/apache/cordova-ios/pull/1154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc931bf) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4c8136345ae9622646ee7e4eb60ba2b37ad44fbe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c81363) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/1154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1154 +/- ##
=======================================
Coverage 74.86% 74.86%
=======================================
Files 13 13
Lines 1723 1723
=======================================
Hits 1290 1290
Misses 433 433
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4c81363...fc931bf](https://codecov.io/gh/apache/cordova-ios/pull/1154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org