You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/08/05 15:07:22 UTC
[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request #863: MINIFICPP-1318 move test rocksdb state to /var/tmp
szaszm opened a new pull request #863:
URL: https://github.com/apache/nifi-minifi-cpp/pull/863
Missed TailFileTests state storage in #862
______
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm edited a comment on pull request #863: MINIFICPP-1318 move test rocksdb state to /var/tmp
Posted by GitBox <gi...@apache.org>.
szaszm edited a comment on pull request #863:
URL: https://github.com/apache/nifi-minifi-cpp/pull/863#issuecomment-669270931
> There are a lot more:
>
> ```
> ~/src/minifi$ git grep '"/tmp' | wc -l
> 147
> ```
>
> the rest do not need to be changed?
They are fine as long as we don't try to create a rocksdb database there. The problem is that rocksdb is configured to use direct IO, i.e. bypass the page cache, but tmpfs is just a mounted page cache without backing storage, so it makes no sense to use direct IO there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #863: WIP: MINIFICPP-1318 move test rocksdb state to /var/tmp
Posted by GitBox <gi...@apache.org>.
szaszm closed pull request #863:
URL: https://github.com/apache/nifi-minifi-cpp/pull/863
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #863: WIP: MINIFICPP-1318 move test rocksdb state to /var/tmp
Posted by GitBox <gi...@apache.org>.
adam-markovics commented on a change in pull request #863:
URL: https://github.com/apache/nifi-minifi-cpp/pull/863#discussion_r478353845
##########
File path: libminifi/test/flow-tests/FlowControllerTests.cpp
##########
@@ -193,7 +198,7 @@ TEST_CASE("Extend the waiting period during shutdown", "[TestFlow4]") {
auto controller = testController.controller_;
auto root = testController.root_;
- int timeout_ms = 1000;
+ unsigned int timeout_ms = 1000;
Review comment:
As this is a duration its type could also be std::chrono::duration, with no _ms suffix needed then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #863: WIP: MINIFICPP-1318 move test rocksdb state to /var/tmp
Posted by GitBox <gi...@apache.org>.
szaszm commented on pull request #863:
URL: https://github.com/apache/nifi-minifi-cpp/pull/863#issuecomment-684936268
The CI issue is fixed in #879, thanks to @fgerlits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda commented on pull request #863: MINIFICPP-1318 move test rocksdb state to /var/tmp
Posted by GitBox <gi...@apache.org>.
arpadboda commented on pull request #863:
URL: https://github.com/apache/nifi-minifi-cpp/pull/863#issuecomment-671029959
@szaszm : not sure if the CI failures we face on U16 jobs are related or not, but I would prefer to investigate before proceeding with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #863: MINIFICPP-1318 move test rocksdb state to /var/tmp
Posted by GitBox <gi...@apache.org>.
szaszm commented on pull request #863:
URL: https://github.com/apache/nifi-minifi-cpp/pull/863#issuecomment-669270931
> There are a lot more:
>
> ```
> ~/src/minifi$ git grep '"/tmp' | wc -l
> 147
> ```
>
> the rest do not need to be changed?
They are fine as long as we don't try to create a rocksdb repository there. The problem is that rocksdb is configured to use direct IO, i.e. bypass the page cache, but tmpfs is just a mounted page cache without backing storage, so it makes no sense to use direct IO there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on pull request #863: WIP: MINIFICPP-1318 move test rocksdb state to /var/tmp
Posted by GitBox <gi...@apache.org>.
fgerlits commented on pull request #863:
URL: https://github.com/apache/nifi-minifi-cpp/pull/863#issuecomment-671219914
> @szaszm : not sure if the CI failures we face on U16 jobs are related or not, but I would prefer to investigate before proceeding with this.
I am 99% sure that both of those failures in TailFileTests are due to the bug fixed in #859. That PR has been merged now, so rebasing on top of it should get rid of the test failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org