[jira] [Commented] (MSHARED-681) Maven-Shared: Java7Support silently fails overwriting symlinks

["Robert James Oxspring (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHARED-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109652#comment-17109652 ] 

Robert James Oxspring commented on MSHARED-681:
-----------------------------------------------

Updated PR opened, inspired by [~mkarg]'s changes but avoiding recreation of identical symlinks and adding a test:

https://github.com/apache/maven-shared-utils/pull/31

> Maven-Shared: Java7Support silently fails overwriting symlinks
> --------------------------------------------------------------
>
>                 Key: MSHARED-681
>                 URL: https://issues.apache.org/jira/browse/MSHARED-681
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-shared-utils
>            Reporter: Markus Karg
>            Priority: Critical
>
> When A is an existing symlink to B, then createSymbolicLink(A,C) does
> neither overwrite A->B by A->C (as expected in analogy to the behavior
> of copy(A,C)) nor does it throw an exception nor does it return A->B to
> indicate the failure, but it actually "silently fails", i. e. it returns
> A->C!
> This certainly is heavily problematic, unsymmetric to what
> copy(File,File) and Files.createSymbolicLink(Path,Path) do, and
> certainly unwanted and buggy behavior.
> The solution is to delete any existing target before creating the
> symlic, hence copying the behavior of copy(File,File).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)