You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Gus Heck (Jira)" <ji...@apache.org> on 2021/12/05 05:28:00 UTC
[jira] [Commented] (SOLR-15590) Start up Core Container via ServletContextListener
[ https://issues.apache.org/jira/browse/SOLR-15590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453521#comment-17453521 ]
Gus Heck commented on SOLR-15590:
---------------------------------
[~thelabdude] After reading code a bit more, reproducing your problem locally and thinking a bit I decided it was not right for any part of core container startup code to know anything about SSL, which should be orthogonal, so rather than the solution we discussed on slack, so I moved the call to SSLConfigurationsFactory.current().init() into the jetty-ssl.xml config since that ensures that no matter what context listener, filter, servlet or other code decides to create an HTTP client, it will not need to rely on some other class being set up first.
> Start up Core Container via ServletContextListener
> --------------------------------------------------
>
> Key: SOLR-15590
> URL: https://issues.apache.org/jira/browse/SOLR-15590
> Project: Solr
> Issue Type: Improvement
> Affects Versions: main (9.0)
> Reporter: Gus Heck
> Assignee: Gus Heck
> Priority: Major
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> Anyone who has had to work on HttpSolrCall, or SolrDispatchFilter will have noticed that we have a LOT going on and that it gets very convoluted. This is bad for maintenance, and probably also bad for performance. After reading for a while I suspect that the primary thing that has lead to this is that the only way to get a reference to CoreContainer is to be in or initialized in or invoked by the SolrDispatchFilter or HttpSolrCall classes.
> To isolate the startup code and not distract from the dispatch code and also to make it possible to later add features that don't live in SolrDispatchFilter and also possibly to split out some features from SolrDispatchFilter into servlets or separate filters, this ticket moves CoreContainer into a CoreService class that will provide CoreContainer and a few other objects like the httpclient to other components that need it.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org