You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "devinrsmith (via GitHub)" <gi...@apache.org> on 2025/05/22 23:54:59 UTC
[PR] AWS: Configure Default s3Async credentials the same as s3 [iceberg]
devinrsmith opened a new pull request, #13132:
URL: https://github.com/apache/iceberg/pull/13132
Closes #13131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS: Configure Default s3Async credentials the same as s3 [iceberg]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer merged PR #13132:
URL: https://github.com/apache/iceberg/pull/13132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS: Configure Default s3Async credentials the same as s3 [iceberg]
Posted by "devinrsmith (via GitHub)" <gi...@apache.org>.
devinrsmith commented on PR #13132:
URL: https://github.com/apache/iceberg/pull/13132#issuecomment-2904530671
@SanjayMarreddi, I think should look at this since you were responsible for https://github.com/apache/iceberg/pull/12503?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS: Configure Default s3Async credentials the same as s3 [iceberg]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on code in PR #13132:
URL: https://github.com/apache/iceberg/pull/13132#discussion_r2114213148
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -966,6 +966,22 @@ public <T extends S3ClientBuilder> void applyCredentialConfigurations(
: awsClientProperties.credentialsProvider(accessKeyId, secretAccessKey, sessionToken));
}
+ public <T extends S3AsyncClientBuilder> void applyCredentialConfigurations(
Review Comment:
Are these two different hierarchies? Just wondering why we need two versions of this but I'm not familiar with AWS's code here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS: Configure Default s3Async credentials the same as s3 [iceberg]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on PR #13132:
URL: https://github.com/apache/iceberg/pull/13132#issuecomment-2920141499
Merged. Thanks for the contribution @devinrsmith and the reviews @malhotrashivam !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS: Configure Default s3Async credentials the same as s3 [iceberg]
Posted by "devinrsmith (via GitHub)" <gi...@apache.org>.
devinrsmith commented on code in PR #13132:
URL: https://github.com/apache/iceberg/pull/13132#discussion_r2114273486
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -966,6 +966,22 @@ public <T extends S3ClientBuilder> void applyCredentialConfigurations(
: awsClientProperties.credentialsProvider(accessKeyId, secretAccessKey, sessionToken));
}
+ public <T extends S3AsyncClientBuilder> void applyCredentialConfigurations(
Review Comment:
Great suggestion. There is a shared hierarchy targeted for `S3ClientBuilder` and `S3AsyncClientBuilder` that is part of the AWS public API, `S3BaseClientBuilder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org