You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/04/07 15:26:04 UTC
[kudu-CR](branch-1.17.x) KUDU-3564: Fix IN list predicate pruning
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21253
Change subject: KUDU-3564: Fix IN list predicate pruning
......................................................................
KUDU-3564: Fix IN list predicate pruning
This patch fixes IN list predicate pruning with a range specific
hash schema by modifying the content of 'PartitionMayContainRow'
method. We now get the right hash schema based on specific
partition's lower bound key.
This is a follow-up to 607d9d0.
Change-Id: I964b1ccfb85602741843ab555cdee53343217033
Reviewed-on: http://gerrit.cloudera.org:8080/21243
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 5a2c776dfb894310fc286f3ebe60d53c8a5e9341)
---
M src/kudu/common/column_predicate.cc
M src/kudu/common/partition.cc
M src/kudu/common/scan_spec-test.cc
3 files changed, 93 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/21253/1
--
To view, visit http://gerrit.cloudera.org:8080/21253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I964b1ccfb85602741843ab555cdee53343217033
Gerrit-Change-Number: 21253
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR](branch-1.17.x) KUDU-3564: Fix IN list predicate pruning
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21253 )
Change subject: KUDU-3564: Fix IN list predicate pruning
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I964b1ccfb85602741843ab555cdee53343217033
Gerrit-Change-Number: 21253
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sun, 07 Apr 2024 19:33:32 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3564: Fix IN list predicate pruning
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21253 )
Change subject: KUDU-3564: Fix IN list predicate pruning
......................................................................
KUDU-3564: Fix IN list predicate pruning
This patch fixes IN list predicate pruning with a range specific
hash schema by modifying the content of 'PartitionMayContainRow'
method. We now get the right hash schema based on specific
partition's lower bound key.
This is a follow-up to 607d9d0.
Change-Id: I964b1ccfb85602741843ab555cdee53343217033
Reviewed-on: http://gerrit.cloudera.org:8080/21243
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 5a2c776dfb894310fc286f3ebe60d53c8a5e9341)
Reviewed-on: http://gerrit.cloudera.org:8080/21253
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/common/column_predicate.cc
M src/kudu/common/partition.cc
M src/kudu/common/scan_spec-test.cc
3 files changed, 93 insertions(+), 14 deletions(-)
Approvals:
Yifan Zhang: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I964b1ccfb85602741843ab555cdee53343217033
Gerrit-Change-Number: 21253
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR](branch-1.17.x) KUDU-3564: Fix IN list predicate pruning
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21253 )
Change subject: KUDU-3564: Fix IN list predicate pruning
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I964b1ccfb85602741843ab555cdee53343217033
Gerrit-Change-Number: 21253
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sun, 07 Apr 2024 15:52:21 +0000
Gerrit-HasComments: No