[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31877: [SPARK-34783][K8S] Support remote template files

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #31877:
URL: https://github.com/apache/spark/pull/31877#discussion_r596927422



##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesUtilsSuite.scala
##########
@@ -65,4 +65,14 @@ class KubernetesUtilsSuite extends SparkFunSuite {
     assert(sparkPodWithNoContainerName.pod.getSpec.getHostname == HOST)
     assert(sparkPodWithNoContainerName.container.getName == null)
   }
+
+  test("SPARK-34783 Support remote template files") {
+    Seq(
+      getClass.getClassLoader.getResource("template-file.yaml").getFile,
+      "https://raw.githubusercontent.com/apache/spark/master/resource-managers/kubernetes/" +

Review comment:
       Thank you for review, @attilapiros .
   
   > I think it would good to avoid such dependencies.
   
   However, as you know, this follows the existing Spark's K8s test practice.
   
   - https://github.com/apache/spark/blob/master/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/BasicTestsSuite.scala#L114
   
   For your following suggestion, it sounds reasonable. Could you file a JIRA and try it in a separate PR?
   > I am surprised we have not got a jetty based




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org