You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by walterddr <gi...@git.apache.org> on 2017/07/13 04:52:14 UTC
[GitHub] flink pull request #4314: [FLINK-7137] [table] Flink TableAPI supports neste...
GitHub user walterddr opened a pull request:
https://github.com/apache/flink/pull/4314
[FLINK-7137] [table] Flink TableAPI supports nested CompositeType mapped to nullable calcite RelDataType by default
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/walterddr/flink FLINK-7137
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4314.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4314
----
commit 93c475b7da114a3022eb2b6fb8b46ffe8a1a6997
Author: Rong Rong <ro...@uber.com>
Date: 2017-07-13T04:29:16Z
Fixing nested fields not mapped to nullable calcite RelDataType by default
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4314: [FLINK-7137] [table] Flink TableAPI supports nested Compo...
Posted by walterddr <gi...@git.apache.org>.
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/4314
@twalthr Thank you for the suggestion, yeah I think this nullable default to false issue will pop up soon somewhere else, might as well just resolve them all together. I incorporated your suggestions and also add some tests so that the problem could be captured during unitest instead of ITCases. Let me know what your thoughts on this are @fhueske @twalthr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4314: [FLINK-7137] [table] Flink TableAPI supports nested Compo...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/4314
Thanks for the tests @walterddr. I will merge this now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4314: [FLINK-7137] [table] Flink TableAPI supports nested Compo...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4314
Thanks for the PR @walterddr.
This looks good to me.
What do you think @twalthr?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4314: [FLINK-7137] [table] Flink TableAPI supports neste...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4314
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4314: [FLINK-7137] [table] Flink TableAPI supports nested Compo...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/4314
I tried to improve the stability regarding nullable types. This should fix FLINK-7177 and FLINK-7137. It ensures that all types have the correct nullability. By default, types are always nullable. If they are not nullable, than we know it for sure.
https://github.com/apache/flink/compare/master...twalthr:FLINK-7137
What do you think? @walterddr @fhueske
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---