You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/06 21:05:39 UTC
[GitHub] [arrow] jonkeane opened a new pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
jonkeane opened a new pull request #11875:
URL: https://github.com/apache/arrow/pull/11875
This would replace (temporarily) #11796 in a way that might be ship-able as is until Snappy accepts google/snappy#148 and is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-987977431
@github-actions crossbow submit test-fedora-r-clang-sanitizer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-988855668
Revision: a9e77fde90c7094478760a3446d51636a84f2f52
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1269](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1269)
|Task|Status|
|----|------|
|conda-linux-gcc-py36-cpu-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-conda-linux-gcc-py36-cpu-r40)|
|conda-linux-gcc-py37-cpu-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-conda-linux-gcc-py37-cpu-r41)|
|conda-osx-clang-py36-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-conda-osx-clang-py36-r40)|
|conda-osx-clang-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-conda-osx-clang-py37-r41)|
|conda-win-vs2017-py36-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-conda-win-vs2017-py36-r40)|
|conda-win-vs2017-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-conda-win-vs2017-py37-r41)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1269-github-homebrew-r-autobrew)|
|test-fedora-r-clang-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-fedora-r-clang-sanitizer)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1269-github-test-r-arrow-backwards-compatibility)|
|test-r-depsource-auto|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-r-depsource-auto)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1269-github-test-r-depsource-system)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1269-github-test-r-devdocs)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1269-github-test-r-gcc-11)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1269-github-test-r-install-local)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1269-github-test-r-linux-as-cran)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1269-github-test-r-linux-rchk)|
|test-r-linux-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-r-linux-valgrind)|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-r-minimal-build)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1269-github-test-r-offline-maximal)|
|test-r-offline-minimal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-r-offline-minimal)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-r-rhub-ubuntu-gcc-release-latest)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-4.1-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-r-rstudio-r-base-4.1-centos7-devtoolset-8)|
|test-r-rstudio-r-base-4.1-centos8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-r-rstudio-r-base-4.1-centos8)|
|test-r-rstudio-r-base-4.1-focal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-r-rstudio-r-base-4.1-focal)|
|test-r-rstudio-r-base-4.1-opensuse15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-r-rstudio-r-base-4.1-opensuse15)|
|test-r-rstudio-r-base-4.1-opensuse42|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-r-rstudio-r-base-4.1-opensuse42)|
|test-r-ubuntu-21.04|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1269-github-test-r-ubuntu-21.04)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1269-github-test-r-versions)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1269-azure-test-ubuntu-18.04-r-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-988215297
Revision: a9e77fde90c7094478760a3446d51636a84f2f52
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1266](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1266)
|Task|Status|
|----|------|
|test-fedora-r-clang-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1266-azure-test-fedora-r-clang-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-987210646
@github-actions crossbow submit test-fedora-r-clang-sanitizer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-988854735
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#discussion_r764373740
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -81,6 +81,7 @@ ARROW_RAPIDJSON_BUILD_VERSION=1a803826f1197b5e30703afe4b9c0e7dd48074f5
ARROW_RAPIDJSON_BUILD_SHA256_CHECKSUM=0b6b780b6c534bfb0b23d29910bfe361e486bcfeaf106db8bc8995792072905a
ARROW_RE2_BUILD_VERSION=2021-02-02
ARROW_RE2_BUILD_SHA256_CHECKSUM=1396ab50c06c1a8885fb68bf49a5ecfd989163015fd96699a180d6414937f33f
+# 1.1.9 is patched to implement https://github.com/google/snappy/pull/148 if this is bumped, remove the patch
Review comment:
I've tried to flag this, and if we pursue this path, I'll make a Jira that points to each of these lines that need to be deleted when > 1.1.9 is released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-988127441
@github-actions autotune
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-989117713
Benchmark runs are scheduled for baseline = cba23c4633f63fbbb7bde9345fa18330953c9f27 and contender = c2a89e688cf7a501ec1295a0dca5adefc4d2ce46. c2a89e688cf7a501ec1295a0dca5adefc4d2ce46 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/48d5fa9f859e4a23849a6a23e32b492a...813e041e913c400e8715726edc8240f5/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/04560d40922e4429bf5f95e82c4a6ccf...e3e821c7123f404490b7a0c3fa31dc4a/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3b4c609346e546c3a5e1ca074832917f...f62d8521b5464cbc811b16387d2c63d0/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-987211943
Revision: 4c426a5382b63d657c90bf968e2ba95ddf1b223b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1251](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1251)
|Task|Status|
|----|------|
|test-fedora-r-clang-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1251-azure-test-fedora-r-clang-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-987211307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-989079181
The conda failures are known / on master. The test-r-depsource-system failure looks transient (and at the very least unrelated!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane closed pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
jonkeane closed pull request #11875:
URL: https://github.com/apache/arrow/pull/11875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#discussion_r764374055
##########
File path: r/inst/build_arrow_static.sh
##########
@@ -47,6 +47,12 @@ else
ARROW_DEFAULT_PARAM="OFF"
fi
+# Snappy 1.1.9 is patched to implement https://github.com/google/snappy/pull/148 but some platforms don't have
+# patch available, so disable snappy in those cases. If the snappy version is bumped, we should remove this.
+if [ ! $(command -v patch) ]; then
+ ARROW_WITH_SNAPPY=OFF
+fi
Review comment:
For our CI this should not be hit, but is important incase CRAN happens to not have `patch`, it will disable snappy so we don't get a sanitizer error there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-987978637
Revision: b141103f3b33fff723a50248b803b274ed9c8994
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1259](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1259)
|Task|Status|
|----|------|
|test-fedora-r-clang-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1259-azure-test-fedora-r-clang-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-988214659
@github-actions crossbow submit test-fedora-r-clang-sanitizer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-989117713
Benchmark runs are scheduled for baseline = cba23c4633f63fbbb7bde9345fa18330953c9f27 and contender = c2a89e688cf7a501ec1295a0dca5adefc4d2ce46. c2a89e688cf7a501ec1295a0dca5adefc4d2ce46 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/48d5fa9f859e4a23849a6a23e32b492a...813e041e913c400e8715726edc8240f5/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/04560d40922e4429bf5f95e82c4a6ccf...e3e821c7123f404490b7a0c3fa31dc4a/)
[Finished :arrow_down:0.09% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3b4c609346e546c3a5e1ca074832917f...f62d8521b5464cbc811b16387d2c63d0/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#discussion_r764373314
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -620,6 +620,14 @@ else()
"https://github.com/google/snappy/archive/${ARROW_SNAPPY_BUILD_VERSION}.tar.gz"
"https://github.com/ursa-labs/thirdparty/releases/download/latest/snappy-${ARROW_SNAPPY_BUILD_VERSION}.tar.gz"
)
+
+ # This can be removed when https://github.com/google/snappy/pull/148 is released
+ # Some platforms don't have patch, but this is probably ok to skip
+ find_program(patch "patch")
+ if(patch)
+ set(SNAPPY_PATCH_COMMAND "patch" "snappy.cc"
+ "${CMAKE_SOURCE_DIR}/build-support/snappy-UBSAN.patch")
+ endif()
Review comment:
Snappy works without the patch, though it has a UBSAN error, so this patches _if we can_ and moves on if not so we don't break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#discussion_r764372413
##########
File path: ci/scripts/r_docker_configure.sh
##########
@@ -77,5 +77,19 @@ if [ "$ARROW_S3" == "ON" ] || [ "$ARROW_R_DEV" == "TRUE" ]; then
fi
fi
+# Install patch if it doesn't already exist
+if [ ! $(command -v patch) ]; then
+ if [ "`which dnf`" ]; then
+ dnf install -y patch
+ elif [ "`which yum`" ]; then
+ yum install -y patch
+ elif [ "`which zypper`" ]; then
+ zypper install -y patch
+ else
+ apt-get update
+ apt-get install -y patch
+ fi
+fi
Review comment:
This is not strictly necessary (see below where we disable snappy if we can't find `patch`), but it makes sure that we do have `patch` available so we do exercise this code in the sanitizer in our CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-989117713
Benchmark runs are scheduled for baseline = cba23c4633f63fbbb7bde9345fa18330953c9f27 and contender = c2a89e688cf7a501ec1295a0dca5adefc4d2ce46. c2a89e688cf7a501ec1295a0dca5adefc4d2ce46 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/48d5fa9f859e4a23849a6a23e32b492a...813e041e913c400e8715726edc8240f5/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/04560d40922e4429bf5f95e82c4a6ccf...e3e821c7123f404490b7a0c3fa31dc4a/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3b4c609346e546c3a5e1ca074832917f...f62d8521b5464cbc811b16387d2c63d0/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-989117713
Benchmark runs are scheduled for baseline = cba23c4633f63fbbb7bde9345fa18330953c9f27 and contender = c2a89e688cf7a501ec1295a0dca5adefc4d2ce46. c2a89e688cf7a501ec1295a0dca5adefc4d2ce46 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/48d5fa9f859e4a23849a6a23e32b492a...813e041e913c400e8715726edc8240f5/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/04560d40922e4429bf5f95e82c4a6ccf...e3e821c7123f404490b7a0c3fa31dc4a/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3b4c609346e546c3a5e1ca074832917f...f62d8521b5464cbc811b16387d2c63d0/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-988127329
@github-actions crossbow submit test-fedora-r-clang-sanitizer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#issuecomment-988128164
Revision: e1599d3d6b873abcf5eabc184cd60959438a073a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1260](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1260)
|Task|Status|
|----|------|
|test-fedora-r-clang-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1260-azure-test-fedora-r-clang-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org