You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2026/09/01 21:39:43 UTC
[PR] Fix GCP bearer header construction [trafficserver]
bneradt opened a new pull request, #13615:
URL: https://github.com/apache/trafficserver/pull/13615
Build the GCP Authorization header dynamically so long bearer tokens do
not reuse the truncated stack buffer length. Add an end-to-end check
that verifies a token longer than the old buffer is forwarded intact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCP bearer header construction [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on code in PR #13615:
URL: https://github.com/apache/trafficserver/pull/13615#discussion_r4011687802
##########
tests/gold_tests/pluginTest/origin_server_auth/origin_server_auth.test.py:
##########
@@ -68,6 +72,35 @@ def setUpOriginServer(self):
# add request/response
self.server.addResponse("sessionlog.log", request_header, response_header)
+ with open(self.long_gcp_replay, "w", encoding="utf-8") as replay:
+ replay.write(
+ f'''meta:
+ version: "1.0"
+
+sessions:
+- transactions:
+ - client-request:
+ method: "GET"
+ url: /long-gcp-token
+ version: "1.1"
+ headers:
+ fields:
+ - [ uuid, long-gcp-token ]
+ - [ Host, www.example.com ]
+ - [ Authorization, {{ value: "Bearer {self.long_gcp_token}", as: equal }} ]
Review Comment:
IIUC, this line try to check generated `Authorization` header. should it be done in `proxy-request` instead of `client-request`?
```
- proxy-request
headers:
fields:
- [ Authorization, {{ value: "Bearer {self.long_gcp_token}", as: equal }} ]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCP bearer header construction [trafficserver]
Posted by "bneradt (via GitHub) via github" <gi...@trafficserver.apache.org>.
bneradt commented on code in PR #13615:
URL: https://github.com/apache/trafficserver/pull/13615#discussion_r4474237832
##########
tests/uranium_tests/pluginTest/origin_server_auth/gcp_long_token.test.yaml:
##########
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+meta:
+ version: "1.0"
+
+urtest:
+ description: Verify a GCP bearer token longer than the former stack buffer reaches the origin intact
+ requires:
+ plugins: [origin_server_auth.so]
+ server:
+ name: origin
+ client:
+ name: client
+ ats:
+ name: ts
+ process_config:
+ enable_cache: false
+ remap_config:
+ - from: "http://www.example.com/long-gcp-token"
+ to: "http://127.0.0.1:{SERVER_HTTP_PORT}/long-gcp-token"
+ plugins:
+ - name: origin_server_auth.so
+ args:
+ - --access_key
+ - "1234567"
+ - --session_token
+ - "gcp-token-0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789
abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcde
f0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef-tail-after-stack-buffer"
+ - --version
+ - gcpv1
+
+sessions:
+ - transactions:
+ - client-request:
+ method: GET
+ url: /long-gcp-token
+ version: "1.1"
+ headers:
+ fields:
+ - [Host, www.example.com]
+ - [uuid, long-gcp-token]
+ proxy-request:
+ headers:
+ fields:
+ - [Authorization, {value: "Bearer gcp-token-0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789a
bcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef
0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef-tail-after-stack-buffer", as: equal}]
Review Comment:
The replay file doesn't contain a literal `******`. Line 58 already expects the full value, `{value: "Bearer gcp-token-…-tail-after-stack-buffer", as: equal}`. That is the same 2274-character token passed via `--session_token` (I confirmed the two strings are byte-identical). The `******` looks like GitHub masking a `Bearer <token>` string in the diff view.
I checked locally that the replay really verifies the token: `gcp_long_token` passes, and changing one character of the expected value makes it fail, so a truncated header would be caught. No change needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCP bearer header construction [trafficserver]
Posted by "Copilot (via GitHub) via github" <gi...@trafficserver.apache.org>.
Copilot commented on code in PR #13615:
URL: https://github.com/apache/trafficserver/pull/13615#discussion_r4457576531
##########
tests/uranium_tests/pluginTest/origin_server_auth/gcp_long_token.test.yaml:
##########
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+meta:
+ version: "1.0"
+
+urtest:
+ description: Verify a GCP bearer token longer than the former stack buffer reaches the origin intact
+ requires:
+ plugins: [origin_server_auth.so]
+ server:
+ name: origin
+ client:
+ name: client
+ ats:
+ name: ts
+ process_config:
+ enable_cache: false
+ remap_config:
+ - from: "http://www.example.com/long-gcp-token"
+ to: "http://127.0.0.1:{SERVER_HTTP_PORT}/long-gcp-token"
+ plugins:
+ - name: origin_server_auth.so
+ args:
+ - --access_key
+ - "1234567"
+ - --session_token
+ - "gcp-token-0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789
abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcde
f0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef-tail-after-stack-buffer"
+ - --version
+ - gcpv1
+
+sessions:
+ - transactions:
+ - client-request:
+ method: GET
+ url: /long-gcp-token
+ version: "1.1"
+ headers:
+ fields:
+ - [Host, www.example.com]
+ - [uuid, long-gcp-token]
+ proxy-request:
+ headers:
+ fields:
+ - [Authorization, {value: "Bearer gcp-token-0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789a
bcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef
0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef-tail-after-stack-buffer", as: equal}]
Review Comment:
This replay expects the origin-side `Authorization` value to be the literal `******`, but `client-request` sends no Authorization header and `authorizeGcp()` constructs `Bearer <session_token>`. As written, the transaction will fail on this mismatch (and cannot verify that the long token is forwarded intact). Set this expected value to the full `Bearer ` token used in the plugin arguments so the new test both passes and detects truncation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCP bearer header construction [trafficserver]
Posted by "bneradt (via GitHub) via github" <gi...@trafficserver.apache.org>.
bneradt commented on PR #13615:
URL: https://github.com/apache/trafficserver/pull/13615#issuecomment-6641819066
[approve ci urtest 3]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCP bearer header construction [trafficserver]
Posted by "bneradt (via GitHub) via github" <gi...@trafficserver.apache.org>.
bneradt commented on code in PR #13615:
URL: https://github.com/apache/trafficserver/pull/13615#discussion_r4457439959
##########
tests/gold_tests/pluginTest/origin_server_auth/origin_server_auth.test.py:
##########
@@ -68,6 +72,35 @@ def setUpOriginServer(self):
# add request/response
self.server.addResponse("sessionlog.log", request_header, response_header)
+ with open(self.long_gcp_replay, "w", encoding="utf-8") as replay:
+ replay.write(
+ f'''meta:
+ version: "1.0"
+
+sessions:
+- transactions:
+ - client-request:
+ method: "GET"
+ url: /long-gcp-token
+ version: "1.1"
+ headers:
+ fields:
+ - [ uuid, long-gcp-token ]
+ - [ Host, www.example.com ]
+ - [ Authorization, {{ value: "Bearer {self.long_gcp_token}", as: equal }} ]
Review Comment:
Yes, good catch. When this test moved to a Uranium replay (`tests/uranium_tests/pluginTest/origin_server_auth/gcp_long_token.test.yaml`), the `Authorization` check went under `proxy-request` with `as: equal` against the full `Bearer <long token>` value, so it verifies what ATS sends to the origin. Rebased on latest master; the origin_server_auth urtests pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCP bearer header construction [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #13615:
URL: https://github.com/apache/trafficserver/pull/13615#discussion_r3908755136
##########
tests/gold_tests/pluginTest/origin_server_auth/origin_server_auth.test.py:
##########
@@ -68,6 +72,35 @@ def setUpOriginServer(self):
# add request/response
self.server.addResponse("sessionlog.log", request_header, response_header)
+ with open(self.long_gcp_replay, "w", encoding="utf-8") as replay:
+ replay.write(
+ f'''meta:
+ version: "1.0"
+
+sessions:
+- transactions:
+ - client-request:
+ method: "GET"
+ url: /long-gcp-token
+ version: "1.1"
+ headers:
+ fields:
+ - [ uuid, long-gcp-token ]
+ - [ Host, www.example.com ]
+ - [ Authorization, {{ value: "Bearer {self.long_gcp_token}", as: equal }} ]
+
+ server-response:
+ status: 200
+ reason: OK
+ headers:
+ fields:
+ - [ Content-Length, 8 ]
Review Comment:
Strangely, you say this once in a while. It is fine as is though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCP bearer header construction [trafficserver]
Posted by "bryancall (via GitHub) via github" <gi...@trafficserver.apache.org>.
bryancall commented on PR #13615:
URL: https://github.com/apache/trafficserver/pull/13615#issuecomment-6748834130
[approve ci doxygen]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCP bearer header construction [trafficserver]
Posted by "bneradt (via GitHub) via github" <gi...@trafficserver.apache.org>.
bneradt commented on PR #13615:
URL: https://github.com/apache/trafficserver/pull/13615#issuecomment-6752339267
[approve ci format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCP bearer header construction [trafficserver]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13615:
URL: https://github.com/apache/trafficserver/pull/13615#discussion_r3908703859
##########
tests/gold_tests/pluginTest/origin_server_auth/origin_server_auth.test.py:
##########
@@ -68,6 +72,35 @@ def setUpOriginServer(self):
# add request/response
self.server.addResponse("sessionlog.log", request_header, response_header)
+ with open(self.long_gcp_replay, "w", encoding="utf-8") as replay:
+ replay.write(
+ f'''meta:
+ version: "1.0"
+
+sessions:
+- transactions:
+ - client-request:
+ method: "GET"
+ url: /long-gcp-token
+ version: "1.1"
+ headers:
+ fields:
+ - [ uuid, long-gcp-token ]
+ - [ Host, www.example.com ]
+ - [ Authorization, {{ value: "Bearer {self.long_gcp_token}", as: equal }} ]
+
+ server-response:
+ status: 200
+ reason: OK
+ headers:
+ fields:
+ - [ Content-Length, 8 ]
Review Comment:
The generated Proxy Verifier replay YAML is invalid because the list items under `headers: fields:` and `server-response: headers: fields:` are not indented beneath `fields:`. Also, the expected Authorization header is currently `"******"`, which does not validate that the long bearer token is forwarded intact (and will not match `Bearer <token>`).
Indent the YAML list items and set the expected Authorization value to `Bearer {self.long_gcp_token}` so the test actually exercises the long-token behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCP bearer header construction [trafficserver]
Posted by "bryancall (via GitHub) via github" <gi...@trafficserver.apache.org>.
bryancall commented on PR #13615:
URL: https://github.com/apache/trafficserver/pull/13615#issuecomment-6553887311
[approve ci urtest clang-tidy]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCP bearer header construction [trafficserver]
Posted by "bryancall (via GitHub) via github" <gi...@trafficserver.apache.org>.
bryancall commented on PR #13615:
URL: https://github.com/apache/trafficserver/pull/13615#issuecomment-6554042834
[approve ci urtest 1]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org