You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/03 12:59:08 UTC
[GitHub] codecov-io edited a comment on issue #5398: Re-add dashboard short
links
codecov-io edited a comment on issue #5398: Re-add dashboard short links
URL: https://github.com/apache/incubator-superset/pull/5398#issuecomment-405558928
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5398?src=pr&el=h1) Report
> Merging [#5398](https://codecov.io/gh/apache/incubator-superset/pull/5398?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3b6cafc82f860b31fde63511301d9613fb824897?src=pr&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `89.47%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5398?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5398 +/- ##
=========================================
- Coverage 63.28% 63.18% -0.1%
=========================================
Files 349 351 +2
Lines 22121 22204 +83
Branches 2457 2466 +9
=========================================
+ Hits 13999 14030 +31
- Misses 8108 8159 +51
- Partials 14 15 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5398?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset/assets/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/5398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXREYXNoYm9hcmRVcmwuanM=) | `100% <100%> (ø)` | |
| [...erset/assets/src/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1VSTFNob3J0TGlua0J1dHRvbi5qc3g=) | `92.3% <100%> (+0.3%)` | :arrow_up: |
| [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `63.95% <81.25%> (+4.65%)` | :arrow_up: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXJBY3Rpb25zRHJvcGRvd24uanN4) | `81.63% <88.88%> (-0.19%)` | :arrow_down: |
| [...perset/assets/src/components/URLShortLinkModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1VSTFNob3J0TGlua01vZGFsLmpzeA==) | `92.85% <92.85%> (ø)` | |
| [superset/assets/src/modules/visUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/5398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9tb2R1bGVzL3Zpc1V0aWxzLmpz) | `58.33% <0%> (-16.67%)` | :arrow_down: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/5398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.34% <0%> (-6.13%)` | :arrow_down: |
| [superset/assets/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/5398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3N0b3JlLmpz) | `21.95% <0%> (-1.13%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQW5ub3RhdGlvbkxheWVyLmpzeA==) | `22.66% <0%> (-0.7%)` | :arrow_down: |
| [...uperset/assets/src/SqlLab/components/ResultSet.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9SZXN1bHRTZXQuanN4) | `84.21% <0%> (-0.64%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/incubator-superset/pull/5398/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5398?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5398?src=pr&el=footer). Last update [3b6cafc...0c7c33a](https://codecov.io/gh/apache/incubator-superset/pull/5398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org