You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Nathan Beyer (JIRA)" <ji...@apache.org> on 2012/11/26 22:02:58 UTC

[jira] [Created] (THRIFT-1760) [Ruby] Remove unnecessary native protocol code

Nathan Beyer created THRIFT-1760:
------------------------------------

             Summary: [Ruby] Remove unnecessary native protocol code
                 Key: THRIFT-1760
                 URL: https://issues.apache.org/jira/browse/THRIFT-1760
             Project: Thrift
          Issue Type: Improvement
          Components: Ruby - Library
    Affects Versions: 0.9
            Reporter: Nathan Beyer


Within the Ruby library, there is some base protocol code written in C that doesn't need to be. All of this functionality is already defined by the Ruby code. The native code isn't providing any notable performance improvements, but does make the code more difficult to maintain.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1760) [Ruby] Remove unnecessary native protocol code

Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nathan Beyer updated THRIFT-1760:
---------------------------------

    Attachment: THRIFT-1760-remove-unecessary-native-protocol-code.patch

[^THRIFT-1760-remove-unecessary-native-protocol-code.patch]

This patch eliminates the 'ext/protocol.c' and 'ext/protocol.h' files as well as removing references to functions and variables defined and used exclusively within.
                
> [Ruby] Remove unnecessary native protocol code
> ----------------------------------------------
>
>                 Key: THRIFT-1760
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1760
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Ruby - Library
>    Affects Versions: 0.9
>            Reporter: Nathan Beyer
>              Labels: ruby
>         Attachments: THRIFT-1760-remove-unecessary-native-protocol-code.patch
>
>
> Within the Ruby library, there is some base protocol code written in C that doesn't need to be. All of this functionality is already defined by the Ruby code. The native code isn't providing any notable performance improvements, but does make the code more difficult to maintain.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira