You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Janne Hietamäki <ja...@apache.org> on 2007/03/28 11:12:28 UTC
Failing unit tests (WAS: Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version))
On Mar 28, 2007, at 11:23 AM, Al Maw wrote:
>
> Other than that, things I've checked are:
> - Tests all pass.
Hmm. I tried to run the tests, and some of them are failing because
the outputted markup has attributes in wrong order. Tests pass ok
when I use JDK 1.5.0, but with 1.4.2 or 1.6.0 (on OS X) some of them
fail.
This is really a old feature, but may be we should finally find a
decent fix for it. ValueMap/AttributeMap is based on HashMap which
causes the attributes are not in predicted order. SortedMap is one
option, but could we find a more efficient one? Attribute order
really matters only when testing, so modifying the diffutil could be
another option..
What do you think?
Here's one example:
testDetachPageAjaxRequest(wicket.ComponentTest) Time elapsed: 0.008
sec <<< FAILURE!
junit.framework.ComparisonFailure: wicket/
TestDetachPageExpectedResult.html expected:<...wicket:id="comp"
onclick="var wcall=wicketAjaxGet('?wicket:interface=:
0:comp::IBehaviorListener:0', function() { }, function() { });"
id="comp0...> but was:<...id="comp0" onc
lick="var wcall=wicketAjaxGet('?wicket:interface=:
0:comp::IBehaviorListener:0', function() { }, function() { });"
wicket:id="comp...>
at junit.framework.Assert.assertEquals(Assert.java:81)
at wicket.util.diff.DiffUtil.validatePage(DiffUtil.java:106)
Janne
Re: Failing unit tests (WAS: Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version))
Posted by Johan Compagner <jc...@gmail.com>.
can;'t we do a XML based equals?
Most of the time it is xml what we output. So why not do a xml bases compare
johan
On 3/28/07, Janne Hietamäki <ja...@apache.org> wrote:
>
>
> On Mar 28, 2007, at 11:23 AM, Al Maw wrote:
>
> >
> > Other than that, things I've checked are:
> > - Tests all pass.
>
> Hmm. I tried to run the tests, and some of them are failing because
> the outputted markup has attributes in wrong order. Tests pass ok
> when I use JDK 1.5.0, but with 1.4.2 or 1.6.0 (on OS X) some of them
> fail.
>
> This is really a old feature, but may be we should finally find a
> decent fix for it. ValueMap/AttributeMap is based on HashMap which
> causes the attributes are not in predicted order. SortedMap is one
> option, but could we find a more efficient one? Attribute order
> really matters only when testing, so modifying the diffutil could be
> another option..
>
> What do you think?
>
> Here's one example:
>
> testDetachPageAjaxRequest(wicket.ComponentTest) Time elapsed: 0.008
> sec <<< FAILURE!
> junit.framework.ComparisonFailure: wicket/
> TestDetachPageExpectedResult.html expected:<...wicket:id="comp"
> onclick="var wcall=wicketAjaxGet('?wicket:interface=:
> 0:comp::IBehaviorListener:0', function() { }, function() { });"
> id="comp0...> but was:<...id="comp0" onc
> lick="var wcall=wicketAjaxGet('?wicket:interface=:
> 0:comp::IBehaviorListener:0', function() { }, function() { });"
> wicket:id="comp...>
> at junit.framework.Assert.assertEquals(Assert.java:81)
> at wicket.util.diff.DiffUtil.validatePage(DiffUtil.java:106)
>
>
> Janne
>
Re: Failing unit tests (WAS: Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version))
Posted by Eelco Hillenius <ee...@gmail.com>.
Depends on what is easier to fix. I'm certainly not for changing to a
less efficient implementation just for the sake of the unit tests, so
if the DiffUtil could be changed, that would be great. IMO, our unit
tests are too brittle anyway, so a diffutil that would be a little bit
smarter would be very nice.
Eelco
On 3/28/07, Janne Hietamäki <ja...@apache.org> wrote:
>
> On Mar 28, 2007, at 11:23 AM, Al Maw wrote:
>
> >
> > Other than that, things I've checked are:
> > - Tests all pass.
>
> Hmm. I tried to run the tests, and some of them are failing because
> the outputted markup has attributes in wrong order. Tests pass ok
> when I use JDK 1.5.0, but with 1.4.2 or 1.6.0 (on OS X) some of them
> fail.
>
> This is really a old feature, but may be we should finally find a
> decent fix for it. ValueMap/AttributeMap is based on HashMap which
> causes the attributes are not in predicted order. SortedMap is one
> option, but could we find a more efficient one? Attribute order
> really matters only when testing, so modifying the diffutil could be
> another option..
>
> What do you think?
>
> Here's one example:
>
> testDetachPageAjaxRequest(wicket.ComponentTest) Time elapsed: 0.008
> sec <<< FAILURE!
> junit.framework.ComparisonFailure: wicket/
> TestDetachPageExpectedResult.html expected:<...wicket:id="comp"
> onclick="var wcall=wicketAjaxGet('?wicket:interface=:
> 0:comp::IBehaviorListener:0', function() { }, function() { });"
> id="comp0...> but was:<...id="comp0" onc
> lick="var wcall=wicketAjaxGet('?wicket:interface=:
> 0:comp::IBehaviorListener:0', function() { }, function() { });"
> wicket:id="comp...>
> at junit.framework.Assert.assertEquals(Assert.java:81)
> at wicket.util.diff.DiffUtil.validatePage(DiffUtil.java:106)
>
>
> Janne
>
Re: Failing unit tests (WAS: Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version))
Posted by Janne Hietamäki <ja...@punainen.org>.
Yeah, that's why I changed the subject..
On Mar 28, 2007, at 12:58 PM, Martijn Dashorst wrote:
> This is a known issue and does not hold back the release.
>
> Martijn
>
> On 3/28/07, Janne Hietamäki <ja...@apache.org> wrote:
>>
>> On Mar 28, 2007, at 11:23 AM, Al Maw wrote:
>>
>> >
>> > Other than that, things I've checked are:
>> > - Tests all pass.
>>
>> Hmm. I tried to run the tests, and some of them are failing because
>> the outputted markup has attributes in wrong order. Tests pass ok
>> when I use JDK 1.5.0, but with 1.4.2 or 1.6.0 (on OS X) some of them
>> fail.
>>
>> This is really a old feature, but may be we should finally find a
>> decent fix for it. ValueMap/AttributeMap is based on HashMap which
>> causes the attributes are not in predicted order. SortedMap is one
>> option, but could we find a more efficient one? Attribute order
>> really matters only when testing, so modifying the diffutil could be
>> another option..
>>
>> What do you think?
>>
>> Here's one example:
>>
>> testDetachPageAjaxRequest(wicket.ComponentTest) Time elapsed: 0.008
>> sec <<< FAILURE!
>> junit.framework.ComparisonFailure: wicket/
>> TestDetachPageExpectedResult.html expected:<...wicket:id="comp"
>> onclick="var wcall=wicketAjaxGet('?wicket:interface=:
>> 0:comp::IBehaviorListener:0', function() { }, function() { });"
>> id="comp0...> but was:<...id="comp0" onc
>> lick="var wcall=wicketAjaxGet('?wicket:interface=:
>> 0:comp::IBehaviorListener:0', function() { }, function() { });"
>> wicket:id="comp...>
>> at junit.framework.Assert.assertEquals(Assert.java:81)
>> at wicket.util.diff.DiffUtil.validatePage(DiffUtil.java:106)
>>
>>
>> Janne
>>
>
>
> --
> Learn Wicket at ApacheCon Europe: http://apachecon.com
> Join the wicket community at irc.freenode.net: ##wicket
> Wicket 1.2.5 will keep your server alive. Download Wicket now!
> http://wicketframework.org
Re: Failing unit tests (WAS: Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version))
Posted by Janne Hietamäki <ja...@apache.org>.
Yup, that's why I changed the subject.
Janne
On Mar 28, 2007, at 12:58 PM, Martijn Dashorst wrote:
> This is a known issue and does not hold back the release.
>
> Martijn
>
> On 3/28/07, Janne Hietamäki <ja...@apache.org> wrote:
>>
>> On Mar 28, 2007, at 11:23 AM, Al Maw wrote:
>>
>> >
>> > Other than that, things I've checked are:
>> > - Tests all pass.
>>
>> Hmm. I tried to run the tests, and some of them are failing because
>> the outputted markup has attributes in wrong order. Tests pass ok
>> when I use JDK 1.5.0, but with 1.4.2 or 1.6.0 (on OS X) some of them
>> fail.
>>
>> This is really a old feature, but may be we should finally find a
>> decent fix for it. ValueMap/AttributeMap is based on HashMap which
>> causes the attributes are not in predicted order. SortedMap is one
>> option, but could we find a more efficient one? Attribute order
>> really matters only when testing, so modifying the diffutil could be
>> another option..
>>
>> What do you think?
>>
>> Here's one example:
>>
>> testDetachPageAjaxRequest(wicket.ComponentTest) Time elapsed: 0.008
>> sec <<< FAILURE!
>> junit.framework.ComparisonFailure: wicket/
>> TestDetachPageExpectedResult.html expected:<...wicket:id="comp"
>> onclick="var wcall=wicketAjaxGet('?wicket:interface=:
>> 0:comp::IBehaviorListener:0', function() { }, function() { });"
>> id="comp0...> but was:<...id="comp0" onc
>> lick="var wcall=wicketAjaxGet('?wicket:interface=:
>> 0:comp::IBehaviorListener:0', function() { }, function() { });"
>> wicket:id="comp...>
>> at junit.framework.Assert.assertEquals(Assert.java:81)
>> at wicket.util.diff.DiffUtil.validatePage(DiffUtil.java:106)
>>
>>
>> Janne
>>
>
>
> --
> Learn Wicket at ApacheCon Europe: http://apachecon.com
> Join the wicket community at irc.freenode.net: ##wicket
> Wicket 1.2.5 will keep your server alive. Download Wicket now!
> http://wicketframework.org
Re: Failing unit tests (WAS: Re: [VOTE] release wicket-1.3.0-incubating-alpha (new version))
Posted by Martijn Dashorst <ma...@gmail.com>.
This is a known issue and does not hold back the release.
Martijn
On 3/28/07, Janne Hietamäki <ja...@apache.org> wrote:
>
> On Mar 28, 2007, at 11:23 AM, Al Maw wrote:
>
> >
> > Other than that, things I've checked are:
> > - Tests all pass.
>
> Hmm. I tried to run the tests, and some of them are failing because
> the outputted markup has attributes in wrong order. Tests pass ok
> when I use JDK 1.5.0, but with 1.4.2 or 1.6.0 (on OS X) some of them
> fail.
>
> This is really a old feature, but may be we should finally find a
> decent fix for it. ValueMap/AttributeMap is based on HashMap which
> causes the attributes are not in predicted order. SortedMap is one
> option, but could we find a more efficient one? Attribute order
> really matters only when testing, so modifying the diffutil could be
> another option..
>
> What do you think?
>
> Here's one example:
>
> testDetachPageAjaxRequest(wicket.ComponentTest) Time elapsed: 0.008
> sec <<< FAILURE!
> junit.framework.ComparisonFailure: wicket/
> TestDetachPageExpectedResult.html expected:<...wicket:id="comp"
> onclick="var wcall=wicketAjaxGet('?wicket:interface=:
> 0:comp::IBehaviorListener:0', function() { }, function() { });"
> id="comp0...> but was:<...id="comp0" onc
> lick="var wcall=wicketAjaxGet('?wicket:interface=:
> 0:comp::IBehaviorListener:0', function() { }, function() { });"
> wicket:id="comp...>
> at junit.framework.Assert.assertEquals(Assert.java:81)
> at wicket.util.diff.DiffUtil.validatePage(DiffUtil.java:106)
>
>
> Janne
>
--
Learn Wicket at ApacheCon Europe: http://apachecon.com
Join the wicket community at irc.freenode.net: ##wicket
Wicket 1.2.5 will keep your server alive. Download Wicket now!
http://wicketframework.org