[jira] Updated: (WW-2655) cssClass attribute in fielderror tag should be applied to the outside element

["Wes Wannemacher (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/struts/browse/WW-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes Wannemacher updated WW-2655:
--------------------------------

    Attachment: WW-2655.patch

I went ahead and took a stab at this one (despite my limited freemarker knowledge). I had to change the styles as well b/c moving the cssClass to the UL ended up centering the whole list which looked pretty bad. Pleas, take a look at the patch. If no one objects, I am going to go ahead and commit. 

> cssClass attribute in fielderror tag should be applied to the outside element
> -----------------------------------------------------------------------------
>
>                 Key: WW-2655
>                 URL: https://issues.apache.org/struts/browse/WW-2655
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.0.11.1
>            Reporter: Hernan J. Gonzalez
>            Assignee: Wes Wannemacher
>            Priority: Minor
>             Fix For: 2.1.3
>
>         Attachments: WW-2655.patch
>
>
> The "cssClass" or "cssStyle" attributes on a <s:fielderror> tag is not applied to the outside <ul> element, but to the inside <span> element. I believe this goes against good css practice, and it limits with no good reason the css-customization.
> <ul class="myClass"><li><span>error msg</span></li></ul>
> is clearly better than the present
> <ul><li><span class="myClass">error msg</span></li></ul>
> because the former allows to style everything inside the whole element (for example, the <li> styles)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.