[GitHub] wes3 commented on issue #379: Some improvements for Extended Advertiser

[gi...@git.apache.org]

wes3 commented on issue #379: Some improvements for Extended Advertiser
URL: https://github.com/apache/mynewt-core/pull/379#issuecomment-313294354
 
 
   As you mentioned in your comments the code does not support mbuf chaining when creating advertising PDU's or scan response PDU's. This means that the maximum amount of advertising data you can send is based on the mbuf size. Since the user can change the mbuf size and amount of EXT_ADV_DATA I think there should be some check added to the code. Maybe a #error for now until we decide if we want to address this issue in a different way (the #error would check if the mbuf size is too small to create a maximum size advertising pdu).
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services