You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/05/19 03:56:49 UTC
Review Request 34387: Moved up Slave and Framework structs in
master.hpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34387/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-2507
https://issues.apache.org/jira/browse/MESOS-2507
Repository: mesos
Description
-------
This is a pure code movement to pull up the Slave and Framework structs, needed for: https://reviews.apache.org/r/34388/
Unfortunately the diff renders terribly, not sure why, but it is a pure code movement.
Diffs
-----
src/master/master.hpp da0a83510784f4f7dbd933e666ac12c04c413a62
Diff: https://reviews.apache.org/r/34387/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 34387: Moved up Slave and Framework structs in
master.hpp.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34387/#review84354
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 19, 2015, 1:56 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34387/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 1:56 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2507
> https://issues.apache.org/jira/browse/MESOS-2507
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a pure code movement to pull up the Slave and Framework structs, needed for: https://reviews.apache.org/r/34388/
>
> Unfortunately the diff renders terribly, not sure why, but it is a pure code movement.
>
>
> Diffs
> -----
>
> src/master/master.hpp da0a83510784f4f7dbd933e666ac12c04c413a62
>
> Diff: https://reviews.apache.org/r/34387/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 34387: Moved up Slave and Framework structs in
master.hpp.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34387/#review84254
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34387]
All tests passed.
- Mesos ReviewBot
On May 19, 2015, 1:56 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34387/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 1:56 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2507
> https://issues.apache.org/jira/browse/MESOS-2507
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a pure code movement to pull up the Slave and Framework structs, needed for: https://reviews.apache.org/r/34388/
>
> Unfortunately the diff renders terribly, not sure why, but it is a pure code movement.
>
>
> Diffs
> -----
>
> src/master/master.hpp da0a83510784f4f7dbd933e666ac12c04c413a62
>
> Diff: https://reviews.apache.org/r/34387/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>