You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/04/01 11:31:59 UTC

[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert opened a new pull request #135: SLING-11241 - Content package with index definitions missing the Oak namespace causes index extraction to fail

rombert opened a new pull request #135:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/135


   Introduce a NamespaceResolver that is aware of the default Oak namespace URI and prefix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert merged pull request #135: SLING-11241 - Content package with index definitions missing the Oak namespace causes index extraction to fail

Posted by GitBox <gi...@apache.org>.
rombert merged pull request #135:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/135


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a change in pull request #135: SLING-11241 - Content package with index definitions missing the Oak namespace causes index extraction to fail

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #135:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/135#discussion_r840508058



##########
File path: src/main/java/org/apache/sling/feature/cpconverter/index/SimpleNamespaceResolver.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.sling.feature.cpconverter.index;
+
+import javax.jcr.NamespaceException;
+
+import org.apache.jackrabbit.spi.commons.namespace.NamespaceResolver;
+
+/**
+ * A simple resolver that is aware of the default {@value #OAK_PREFIX} prefix and namespace
+ */
+public class SimpleNamespaceResolver implements NamespaceResolver {
+
+    // copied from oak-spi-core/NamespaceConstants to not add a dependency on Oak
+    static final String OAK_PREFIX = "oak";
+    static final String OAK_NAMESPACE = "http://jackrabbit.apache.org/oak/ns/1.0";
+
+    @Override
+    public String getURI(String prefix) throws NamespaceException {
+        if ( OAK_PREFIX.equals(prefix) )
+            return OAK_NAMESPACE;
+        return null;

Review comment:
       Returning null is IMHO invalid according to the contract of the interface. You must throw instead




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #135: SLING-11241 - Content package with index definitions missing the Oak namespace causes index extraction to fail

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #135:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/135#issuecomment-1085791365


   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&resolved=false&types=CODE_SMELL)
   
   [![41.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/40-16px.png '41.7%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&metric=new_coverage&view=list) [41.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=135&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert commented on a change in pull request #135: SLING-11241 - Content package with index definitions missing the Oak namespace causes index extraction to fail

Posted by GitBox <gi...@apache.org>.
rombert commented on a change in pull request #135:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/135#discussion_r840526391



##########
File path: src/main/java/org/apache/sling/feature/cpconverter/index/SimpleNamespaceResolver.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.sling.feature.cpconverter.index;
+
+import javax.jcr.NamespaceException;
+
+import org.apache.jackrabbit.spi.commons.namespace.NamespaceResolver;
+
+/**
+ * A simple resolver that is aware of the default {@value #OAK_PREFIX} prefix and namespace
+ */
+public class SimpleNamespaceResolver implements NamespaceResolver {
+
+    // copied from oak-spi-core/NamespaceConstants to not add a dependency on Oak
+    static final String OAK_PREFIX = "oak";
+    static final String OAK_NAMESPACE = "http://jackrabbit.apache.org/oak/ns/1.0";
+
+    @Override
+    public String getURI(String prefix) throws NamespaceException {
+        if ( OAK_PREFIX.equals(prefix) )
+            return OAK_NAMESPACE;
+        return null;

Review comment:
       Good catch, thanks. Fix in https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/136




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org