You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Volker Lamp (Jira)" <ji...@apache.org> on 2021/05/11 21:00:02 UTC

[jira] [Commented] (TAP5-2668) Move spock-tapestry extension to tapestry-test

    [ https://issues.apache.org/jira/browse/TAP5-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342867#comment-17342867 ] 

Volker Lamp commented on TAP5-2668:
-----------------------------------

Unfortunately, the next release of {{spock-tapestry}} is not going to adapt to the breaking changes introduced by Tapestry 5.7, as [~leonard84] indicated in the [discussion|https://github.com/spockframework/spock/pull/1315#discussion_r630230301] related with my pull request towards {{spock-tapestry}}. Actually, it appears to me the Spock maintainers wouldn't mind getting rid of {{spock-tapestry}} altogether.

While sticking with a Tapestry 5.7 compatible {{spock-tapestry}} would be the most convenient solution with regard to existing Spock specs, migrating to {{tapestry-spock}} would still be a better option than having to introduce a third party dependency or rolling one's own Spock extension.

I'm ready to get the adoption work done. It doesn't look very complicated. I'd also volunteer to take care of maintaining the code, so to address your main concern, Thiago. You never know what the future holds, but I've been running and growing a Tapestry 5 based webapp since 2008 and I don't intend to switch to another framework any time soon.

> Move spock-tapestry extension to tapestry-test
> ----------------------------------------------
>
>                 Key: TAP5-2668
>                 URL: https://issues.apache.org/jira/browse/TAP5-2668
>             Project: Tapestry 5
>          Issue Type: Wish
>          Components: tapestry-test
>            Reporter: Leonard Brünings
>            Priority: Major
>
> Hi I'm the maintainer of the Spock Framework and I'd like to propose, that the spock-tapestry extensions is migrated to tapestry-test or tapestry-spock. The current implementation supports only 5.4.3 and a check with 5.7.1 revealed some removed classes that would require another layer of reflection indirection to support different versions.
> In my opinion it would make more sense to move the extension to Tapestry, as this would simplify the code quite a bit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)