[GitHub] sarveshkesharwani edited a comment on issue #877: [NETBEANS-1074] Module Review servletjspapi

[GitBox <gi...@apache.org>]

sarveshkesharwani edited a comment on issue #877: [NETBEANS-1074] Module Review servletjspapi
URL: https://github.com/apache/incubator-netbeans/pull/877#issuecomment-425377178
 
 
   @matthiasblaesing ,  I have mavenized web.jspparser and servletjspapi modules here and I have unified the jars, and I have added licenses for them. I have a couple of questions though : 
   1) What should be the license for the new jars created after unification? Do they even require a license, as they are built in runtime ?
   2) Does the target `create-jars-from-glassfish` in web.jspparser even executed anytime? I ask this because it tries to unify the jars from `{glassfish_location}` the value of which looks like a local address `/home/marfous/Programs/AppServers/glassfish-4.0-b84-custom` that doesn't even exist.
   I have created a target `build-init` for unification of jars in both servletjspapi and web.jspparser
   Also, it looks like the tests are broken for web.jspparser module, because I tried to run the unit tests with and without my changes and I see that in both the cases, it tries to unzip `project3.zip` which isn't present. I am looking into this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists