[GitHub] [arrow-site] kou commented on a change in pull request #141: ARROW-13693: [Documentation] use ruby version 3.0.2 and migrate action

[GitBox <gi...@apache.org>]

kou commented on a change in pull request #141:
URL: https://github.com/apache/arrow-site/pull/141#discussion_r694282836



##########
File path: .github/workflows/deploy.yml
##########
@@ -29,8 +29,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-ruby@v1
+      - uses: ruby/setup-ruby@v1
       - uses: actions/setup-node@v2
+        with:
+          ruby-version: 3.0.2
+          bundler-cache: true

Review comment:
       We should specify `ruby-version` and `bundler-cache` to `ruby/setup-ruby` not `actions/setup-node`:
   
   ```suggestion
         - uses: ruby/setup-ruby@v1
           with:
             ruby-version: "3.0"
             bundler-cache: true
         - uses: actions/setup-node@v2
   ```
   
   And we can use `"3.0"` instead of `3.0.2`. `"3.0"` can use the latest Ruby 3.0.X automatically. We don't need to care minor version in this repository.

##########
File path: .ruby-version
##########
@@ -0,0 +1 @@
+3.0.2

Review comment:
       We don't need this file because we specify Ruby version to `ruby/setup-ruby` explicitly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org