You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Alexander Alten-Lorenz <al...@cloudera.com> on 2012/11/06 10:28:59 UTC

Review Request: HDFEventSink throws NPE if event is generated without timestamp in header

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7896/
-----------------------------------------------------------

Review request for Flume.


Description
-------

HDFEventSink throws NPE if event is generated without timestamp in header. The fix uses timestamp interceptor.


This addresses bug FLUME-1264.
    https://issues.apache.org/jira/browse/FLUME-1264


Diffs
-----

  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java e369604 

Diff: https://reviews.apache.org/r/7896/diff/


Testing
-------

Tests passed against Flume NG Node 1.4.0-SNAPSHOT


Thanks,

Alexander Alten-Lorenz


Re: Review Request: HDFEventSink throws NPE if event is generated without timestamp in header

Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7896/#review13138
-----------------------------------------------------------



flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
<https://reviews.apache.org/r/7896/#comment28294>

    remove spaces



flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
<https://reviews.apache.org/r/7896/#comment28295>

    remove spaces



flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
<https://reviews.apache.org/r/7896/#comment28296>

    remove spaces



flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
<https://reviews.apache.org/r/7896/#comment28297>

    remove spaces


- Alexander Alten-Lorenz


On Nov. 6, 2012, 9:28 a.m., Alexander Alten-Lorenz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7896/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 9:28 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> HDFEventSink throws NPE if event is generated without timestamp in header. The fix uses timestamp interceptor.
> 
> 
> This addresses bug FLUME-1264.
>     https://issues.apache.org/jira/browse/FLUME-1264
> 
> 
> Diffs
> -----
> 
>   flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java e369604 
> 
> Diff: https://reviews.apache.org/r/7896/diff/
> 
> 
> Testing
> -------
> 
> Tests passed against Flume NG Node 1.4.0-SNAPSHOT
> 
> 
> Thanks,
> 
> Alexander Alten-Lorenz
> 
>


Re: Review Request: HDFEventSink throws NPE if event is generated without timestamp in header

Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7896/
-----------------------------------------------------------

(Updated Nov. 6, 2012, 9:32 a.m.)


Review request for Flume.


Changes
-------

spaces removed


Description
-------

HDFEventSink throws NPE if event is generated without timestamp in header. The fix uses timestamp interceptor.


This addresses bug FLUME-1264.
    https://issues.apache.org/jira/browse/FLUME-1264


Diffs (updated)
-----

  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java e369604 

Diff: https://reviews.apache.org/r/7896/diff/


Testing
-------

Tests passed against Flume NG Node 1.4.0-SNAPSHOT


Thanks,

Alexander Alten-Lorenz