[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4712: marvin: Bypass tests on Simulator

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4712:
URL: https://github.com/apache/cloudstack/pull/4712#discussion_r579156786



##########
File path: test/integration/smoke/test_network.py
##########
@@ -2018,12 +2024,14 @@ def test_02_verifyRouterIpAfterNetworkRestart(self):
 
     @attr(tags=["advanced", "shared"])
     def test_03_destroySharedNetwork(self):
+        if self.hv.lower() == 'simulator':
+            self.skipTest("Hypervisor is simulator - skipping Test..")
         routerIp = self.services["shared_network"]["routerip"]
         try:
             self.shared_network.delete(self.apiclient)
         except Exception as e:
             self.fail("Failed to destroy the shared network")
-
+        self._cleanup.remove(self.shared_network)

Review comment:
       this should be done in the teardown method,




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org