You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/22 08:56:41 UTC
[GitHub] [pulsar] murong00 opened a new pull request #8103: [pulsar-broker] Added support to force deleting tenant
murong00 opened a new pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103
### Motivation
Some users expect an option to force deleting tenant for simplicity, it can be useful in some situations.
### Modifications
Add a optional field to force the deletion of all stuffs related to tenant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on pull request #8103: [pulsar-broker] Added support to force deleting tenant
Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#issuecomment-783844598
Close this and submit a new pull request using metadata-api.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on pull request #8103: [pulsar-broker] Added support to force deleting tenant
Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#issuecomment-766637072
@codelipenghui @jiazhai I have added a test, please help to take a review when available, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on pull request #8103: [pulsar-broker] Added support to force deleting tenant
Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#issuecomment-767215380
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on pull request #8103: [pulsar-broker] Added support to force deleting tenant
Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#issuecomment-766637072
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on a change in pull request #8103: [pulsar-broker] Added support to force deleting tenant
Posted by GitBox <gi...@apache.org>.
murong00 commented on a change in pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#discussion_r524909204
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminTest.java
##########
@@ -455,9 +455,11 @@ public void properties() throws Exception {
assertEquals(e.getResponse().getStatus(), Status.NOT_FOUND.getStatusCode());
}
+ AsyncResponse response = mock(AsyncResponse.class);
+
// Check deleting non-existing property
try {
- properties.deleteTenant("non-existing");
+ properties.deleteTenant(response, "non-existing", false);
Review comment:
This change adds a force option so the test need pass this option. I can add a test to cover the above situations later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #8103: [pulsar-broker] Added support to force deleting tenant
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#discussion_r524848532
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminTest.java
##########
@@ -455,9 +455,11 @@ public void properties() throws Exception {
assertEquals(e.getResponse().getStatus(), Status.NOT_FOUND.getStatusCode());
}
+ AsyncResponse response = mock(AsyncResponse.class);
+
// Check deleting non-existing property
try {
- properties.deleteTenant("non-existing");
+ properties.deleteTenant(response, "non-existing", false);
Review comment:
Is the test related to this change? I think the test should cover there are namespaces and topics under a tenant, then we delete the tenant forcefully should success.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8103: [pulsar-broker] Added support to force deleting tenant
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#issuecomment-728649861
move to 2.8.0 first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8103: [pulsar-broker] Added support to force deleting tenant
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#issuecomment-699651525
I've fixed the `testIndividualAck` cpp unit test failure in #8141 , please rebase and commit again, thx!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 closed pull request #8103: [pulsar-broker] Added support to force deleting tenant
Posted by GitBox <gi...@apache.org>.
murong00 closed pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on pull request #8103: [pulsar-broker] Added support to force deleting tenant
Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#issuecomment-728716410
> move to 2.8.0 first
@codelipenghui I can add a test to cover your comments and we expect this feature as soon as possilbe. Can this be introduced in coming 2.7.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 removed a comment on pull request #8103: [pulsar-broker] Added support to force deleting tenant
Posted by GitBox <gi...@apache.org>.
murong00 removed a comment on pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#issuecomment-767215380
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on pull request #8103: [pulsar-broker] Added support to force deleting tenant
Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#issuecomment-767462470
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org