You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/27 15:36:17 UTC

[GitHub] [beam] jrmccluskey commented on a diff in pull request #17479: [BEAM-14243] Add staticcheck to Github Actions Precommits

jrmccluskey commented on code in PR #17479:
URL: https://github.com/apache/beam/pull/17479#discussion_r859949592


##########
.github/workflows/go_tests.yml:
##########
@@ -53,3 +53,7 @@ jobs:
         run: cd sdks/go/pkg/beam && go fmt ./...; git diff-index --quiet HEAD || (echo "Run go fmt before checking in changes" && exit 1)
       - name: Run vet
         run: cd sdks/go/pkg/beam && go vet --copylocks=false --unsafeptr=false ./... || (echo "Run go vet and fix warnings before checking in changes" && exit 1)
+      - uses: dominikh/staticcheck-action@v1.1.0
+        with:
+	  version: "2022.1.0"
+          install-go: false

Review Comment:
   That tracks, I quickly threw the change together in Vim and getting the whitespace aligned was giving me fits



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org