[GitHub] [incubator-superset] mistercrunch commented on issue #7530: [SIP-20] Proposal for Implementing Chart Level Custom Calculations

[GitBox <gi...@apache.org>]

mistercrunch commented on issue #7530: [SIP-20] Proposal for Implementing Chart Level Custom Calculations
URL: https://github.com/apache/incubator-superset/issues/7530#issuecomment-493589457
 
 
   I'm not sure if https://github.com/vinci1it2000/formulas is the right choice (though I haven't done any research). It has limited traction. On the license side, we'd also have to make sure that the ASF is ok with it as I don't see it on the approved license list https://apache.org/legal/resolved.html#category-a . I'd hate for the next person to push an Apache release to have to deal with clearing that.
   
   Implementation-wise, I agree this should be backend code as the dataframe is probably the right place to apply this (as opposed to viz-specific code), though I think we have code doing similar things on the frontend for "Annotations" as formulas (I think it's using `math.js`?).
   
   As to where this should be defined: could this be a metric parameter instead? By that I mean your metric definition may [optionally] be a formula and/or reference other metrics?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org