You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/22 11:13:57 UTC
[GitHub] [flink] dawidwys opened a new pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
dawidwys opened a new pull request #19198:
URL: https://github.com/apache/flink/pull/19198
## What is the purpose of the change
This commit reverts to the old behaviour of restoring from a savepoint, if stop-with-savepoint failed while committing results. We should not revert to a checkpoint in this case, because that way we might produce duplicated results.
## Verifying this change
Added test in:
* SavepointITCase
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 063142910173c009e6b8f6e393a4cb87c8185c08 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
}, {
"hash" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745",
"triggerID" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"triggerType" : "PUSH"
}, {
"hash" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33763",
"triggerID" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"triggerType" : "PUSH"
}, {
"hash" : "d1064620741af7f0d2de07470c92d4d024d77688",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33766",
"triggerID" : "d1064620741af7f0d2de07470c92d4d024d77688",
"triggerType" : "PUSH"
}, {
"hash" : "8af7e7a8498025a47cb1cf4d653c9dc28c893309",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8af7e7a8498025a47cb1cf4d653c9dc28c893309",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f1773556290004a8e9fe5ce53ed7ac5c12c641d7 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33763)
* d1064620741af7f0d2de07470c92d4d024d77688 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33766)
* 8af7e7a8498025a47cb1cf4d653c9dc28c893309 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
}, {
"hash" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745",
"triggerID" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"triggerType" : "PUSH"
}, {
"hash" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33763",
"triggerID" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"triggerType" : "PUSH"
}, {
"hash" : "d1064620741af7f0d2de07470c92d4d024d77688",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33766",
"triggerID" : "d1064620741af7f0d2de07470c92d4d024d77688",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f1773556290004a8e9fe5ce53ed7ac5c12c641d7 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33763)
* d1064620741af7f0d2de07470c92d4d024d77688 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33766)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4558ef580afef3ca1990741daceda23ff04f2b4e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #19198:
URL: https://github.com/apache/flink/pull/19198#discussion_r833684250
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1243,7 +1243,7 @@ private void completePendingCheckpoint(PendingCheckpoint pendingCheckpoint)
// the pending checkpoint must be discarded after the finalization
Preconditions.checkState(pendingCheckpoint.isDisposed() && completedCheckpoint != null);
- if (!props.isSavepoint()) {
+ if (!props.isSavepoint() || props.isSynchronous()) {
lastSubsumed =
addCompletedCheckpointToStoreAndSubsumeOldest(
Review comment:
Should we subsume anything in this case? Also isn't this braking savepoint ownership? I mean what if user deletes the savepoint?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #19198:
URL: https://github.com/apache/flink/pull/19198#discussion_r833684250
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1243,7 +1243,7 @@ private void completePendingCheckpoint(PendingCheckpoint pendingCheckpoint)
// the pending checkpoint must be discarded after the finalization
Preconditions.checkState(pendingCheckpoint.isDisposed() && completedCheckpoint != null);
- if (!props.isSavepoint()) {
+ if (!props.isSavepoint() || props.isSynchronous()) {
lastSubsumed =
addCompletedCheckpointToStoreAndSubsumeOldest(
Review comment:
Should we subsume anything in this case? Also isn't this braking savepoint ownership?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #19198:
URL: https://github.com/apache/flink/pull/19198#discussion_r836203434
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointTerminationHandlerImpl.java
##########
@@ -167,16 +166,13 @@ private void handleAnyExecutionNotFinished(Set<ExecutionState> notFinishedExecut
*/
private void terminateExceptionallyWithGlobalFailover(
Iterable<ExecutionState> unfinishedExecutionStates, String savepointPath) {
- String errorMessage =
- String.format(
- "Inconsistent execution state after stopping with savepoint. At least one execution is still in one of the following states: %s. A global fail-over is triggered to recover the job %s.",
- StringUtils.join(unfinishedExecutionStates, ", "), jobId);
- FlinkException inconsistentFinalStateException = new FlinkException(errorMessage);
+ StopWithSavepointException inconsistentFinalStateException =
+ new StopWithSavepointException(savepointPath, jobId);
log.warn(
- "A savepoint was created at {} but the corresponding job {} didn't terminate successfully.",
- savepointPath,
- jobId,
+ "Inconsistent execution state after stopping with savepoint. At least one"
+ + " execution is still in one of the following states: {}.",
+ StringUtils.join(unfinishedExecutionStates, ", "),
inconsistentFinalStateException);
scheduler.handleGlobalFailure(inconsistentFinalStateException);
Review comment:
Shouldn't we change something around the failover behaviour?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointException.java
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.scheduler.stopwithsavepoint;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.throwable.ThrowableAnnotation;
+import org.apache.flink.runtime.throwable.ThrowableType;
+import org.apache.flink.util.FlinkException;
+
+/**
+ * Exception thrown when a savepoint has been created successfully when stopping with savepoint, but
+ * the job has not finished. In that case side-effects might have not been committed. This exception
+ * is used to communicate that to the use.
+ */
+@Experimental
+@ThrowableAnnotation(ThrowableType.NonRecoverableError)
+public class StopWithSavepointException extends FlinkException {
Review comment:
`StopWithSavepointStoppingException`?
`StopWithSavepointExceptionWhenStopping`?
Otherwise, as it is, someone might just (mis)use `StopWithSavepointException` in the future to indicate any type of exception during the stop-with-savepoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 063142910173c009e6b8f6e393a4cb87c8185c08 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* db1d211bc42368395f186c4a0f576ba2f2bd324e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
}, {
"hash" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745",
"triggerID" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"triggerType" : "PUSH"
}, {
"hash" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33763",
"triggerID" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"triggerType" : "PUSH"
}, {
"hash" : "d1064620741af7f0d2de07470c92d4d024d77688",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33766",
"triggerID" : "d1064620741af7f0d2de07470c92d4d024d77688",
"triggerType" : "PUSH"
}, {
"hash" : "8af7e7a8498025a47cb1cf4d653c9dc28c893309",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33771",
"triggerID" : "8af7e7a8498025a47cb1cf4d653c9dc28c893309",
"triggerType" : "PUSH"
}, {
"hash" : "f339cb03b305c436f12e40c48f31add2efc5790d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33825",
"triggerID" : "f339cb03b305c436f12e40c48f31add2efc5790d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8af7e7a8498025a47cb1cf4d653c9dc28c893309 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33771)
* f339cb03b305c436f12e40c48f31add2efc5790d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33825)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
}, {
"hash" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a94229250d76381567afb8668e645903d30441c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712)
* 7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db1d211bc42368395f186c4a0f576ba2f2bd324e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db1d211bc42368395f186c4a0f576ba2f2bd324e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603)
* 4558ef580afef3ca1990741daceda23ff04f2b4e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #19198:
URL: https://github.com/apache/flink/pull/19198#discussion_r836205477
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointTerminationHandlerImpl.java
##########
@@ -167,16 +166,13 @@ private void handleAnyExecutionNotFinished(Set<ExecutionState> notFinishedExecut
*/
private void terminateExceptionallyWithGlobalFailover(
Iterable<ExecutionState> unfinishedExecutionStates, String savepointPath) {
- String errorMessage =
- String.format(
- "Inconsistent execution state after stopping with savepoint. At least one execution is still in one of the following states: %s. A global fail-over is triggered to recover the job %s.",
- StringUtils.join(unfinishedExecutionStates, ", "), jobId);
- FlinkException inconsistentFinalStateException = new FlinkException(errorMessage);
+ StopWithSavepointException inconsistentFinalStateException =
+ new StopWithSavepointException(savepointPath, jobId);
log.warn(
- "A savepoint was created at {} but the corresponding job {} didn't terminate successfully.",
- savepointPath,
- jobId,
+ "Inconsistent execution state after stopping with savepoint. At least one"
+ + " execution is still in one of the following states: {}.",
+ StringUtils.join(unfinishedExecutionStates, ", "),
inconsistentFinalStateException);
scheduler.handleGlobalFailure(inconsistentFinalStateException);
Review comment:
It's done with the annotation on the exception: `@ThrowableAnnotation(ThrowableType.NonRecoverableError)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4558ef580afef3ca1990741daceda23ff04f2b4e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692)
* 4a94229250d76381567afb8668e645903d30441c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
}, {
"hash" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745",
"triggerID" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"triggerType" : "PUSH"
}, {
"hash" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33763",
"triggerID" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"triggerType" : "PUSH"
}, {
"hash" : "d1064620741af7f0d2de07470c92d4d024d77688",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33766",
"triggerID" : "d1064620741af7f0d2de07470c92d4d024d77688",
"triggerType" : "PUSH"
}, {
"hash" : "8af7e7a8498025a47cb1cf4d653c9dc28c893309",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33771",
"triggerID" : "8af7e7a8498025a47cb1cf4d653c9dc28c893309",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8af7e7a8498025a47cb1cf4d653c9dc28c893309 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33771)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
}, {
"hash" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745",
"triggerID" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"triggerType" : "PUSH"
}, {
"hash" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33763",
"triggerID" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"triggerType" : "PUSH"
}, {
"hash" : "d1064620741af7f0d2de07470c92d4d024d77688",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33766",
"triggerID" : "d1064620741af7f0d2de07470c92d4d024d77688",
"triggerType" : "PUSH"
}, {
"hash" : "8af7e7a8498025a47cb1cf4d653c9dc28c893309",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33771",
"triggerID" : "8af7e7a8498025a47cb1cf4d653c9dc28c893309",
"triggerType" : "PUSH"
}, {
"hash" : "f339cb03b305c436f12e40c48f31add2efc5790d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33825",
"triggerID" : "f339cb03b305c436f12e40c48f31add2efc5790d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f339cb03b305c436f12e40c48f31add2efc5790d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33825)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 063142910173c009e6b8f6e393a4cb87c8185c08 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595)
* db1d211bc42368395f186c4a0f576ba2f2bd324e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys closed pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #19198:
URL: https://github.com/apache/flink/pull/19198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
}, {
"hash" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745",
"triggerID" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"triggerType" : "PUSH"
}, {
"hash" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33763",
"triggerID" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"triggerType" : "PUSH"
}, {
"hash" : "d1064620741af7f0d2de07470c92d4d024d77688",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d1064620741af7f0d2de07470c92d4d024d77688",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745)
* f1773556290004a8e9fe5ce53ed7ac5c12c641d7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33763)
* d1064620741af7f0d2de07470c92d4d024d77688 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
}, {
"hash" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745",
"triggerID" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"triggerType" : "PUSH"
}, {
"hash" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33763",
"triggerID" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"triggerType" : "PUSH"
}, {
"hash" : "d1064620741af7f0d2de07470c92d4d024d77688",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33766",
"triggerID" : "d1064620741af7f0d2de07470c92d4d024d77688",
"triggerType" : "PUSH"
}, {
"hash" : "8af7e7a8498025a47cb1cf4d653c9dc28c893309",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33771",
"triggerID" : "8af7e7a8498025a47cb1cf4d653c9dc28c893309",
"triggerType" : "PUSH"
}, {
"hash" : "f339cb03b305c436f12e40c48f31add2efc5790d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f339cb03b305c436f12e40c48f31add2efc5790d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8af7e7a8498025a47cb1cf4d653c9dc28c893309 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33771)
* f339cb03b305c436f12e40c48f31add2efc5790d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* db1d211bc42368395f186c4a0f576ba2f2bd324e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 063142910173c009e6b8f6e393a4cb87c8185c08 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595)
* db1d211bc42368395f186c4a0f576ba2f2bd324e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* db1d211bc42368395f186c4a0f576ba2f2bd324e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4558ef580afef3ca1990741daceda23ff04f2b4e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692)
* 4a94229250d76381567afb8668e645903d30441c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db1d211bc42368395f186c4a0f576ba2f2bd324e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603)
* 4558ef580afef3ca1990741daceda23ff04f2b4e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a94229250d76381567afb8668e645903d30441c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
}, {
"hash" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745",
"triggerID" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"triggerType" : "PUSH"
}, {
"hash" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33763",
"triggerID" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"triggerType" : "PUSH"
}, {
"hash" : "d1064620741af7f0d2de07470c92d4d024d77688",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33766",
"triggerID" : "d1064620741af7f0d2de07470c92d4d024d77688",
"triggerType" : "PUSH"
}, {
"hash" : "8af7e7a8498025a47cb1cf4d653c9dc28c893309",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33771",
"triggerID" : "8af7e7a8498025a47cb1cf4d653c9dc28c893309",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1064620741af7f0d2de07470c92d4d024d77688 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33766)
* 8af7e7a8498025a47cb1cf4d653c9dc28c893309 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33771)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
}, {
"hash" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745",
"triggerID" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"triggerType" : "PUSH"
}, {
"hash" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33763",
"triggerID" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745)
* f1773556290004a8e9fe5ce53ed7ac5c12c641d7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33763)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
}, {
"hash" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745",
"triggerID" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"triggerType" : "PUSH"
}, {
"hash" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f1773556290004a8e9fe5ce53ed7ac5c12c641d7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a94229250d76381567afb8668e645903d30441c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712)
* 7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745)
* f1773556290004a8e9fe5ce53ed7ac5c12c641d7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #19198:
URL: https://github.com/apache/flink/pull/19198#discussion_r833995464
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1243,7 +1243,7 @@ private void completePendingCheckpoint(PendingCheckpoint pendingCheckpoint)
// the pending checkpoint must be discarded after the finalization
Preconditions.checkState(pendingCheckpoint.isDisposed() && completedCheckpoint != null);
- if (!props.isSavepoint()) {
+ if (!props.isSavepoint() || props.isSynchronous()) {
lastSubsumed =
addCompletedCheckpointToStoreAndSubsumeOldest(
Review comment:
1. For the subsumption, we do have a logic that will keep at least one other checkpoint (not-savepoint), so I think that's fine. (see: `CheckpointSubsumeHelper#subsume`).
2. As for the ownership, there are two aspects here. First, we can say savepoint (stop-with-savepoint) is under Flink's control until the job has finished. Secondly, this reverts to the behaviour of <=1.14, the better handling we discussed should be implemented in https://issues.apache.org/jira/browse/FLINK-26683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19198: [FLINK-26783] Do not trigger global failover if failed during commiting side-effects during stop-with-savepoint
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075044557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33595",
"triggerID" : "063142910173c009e6b8f6e393a4cb87c8185c08",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"triggerType" : "PUSH"
}, {
"hash" : "db1d211bc42368395f186c4a0f576ba2f2bd324e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33603",
"triggerID" : "1075883225",
"triggerType" : "MANUAL"
}, {
"hash" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33692",
"triggerID" : "4558ef580afef3ca1990741daceda23ff04f2b4e",
"triggerType" : "PUSH"
}, {
"hash" : "4a94229250d76381567afb8668e645903d30441c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712",
"triggerID" : "4a94229250d76381567afb8668e645903d30441c",
"triggerType" : "PUSH"
}, {
"hash" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745",
"triggerID" : "7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a94229250d76381567afb8668e645903d30441c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33712)
* 7933101b4fcaf3a14fd0f50b1f4ccadc68b75b35 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33745)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1077370537
After an offline discussion we said that indeed this approach poses a problem for the savepoint ownership, as after a restart the savepoint will remain in the `CompletedCheckpointStore` and Flink will depend on its existence.
Therefore we propose a different approach to solve the issue that if we fallback to a checkpoint we might end up with duplicated records. We suggest to already not trigger a global failover in case the savepoint completed successfully, but the job failed during committing side effects. In that case we will finish the completable future with an exception that explains that the savepoint is consistent, but it might have uncommitted side effects and ask users to manually restart a job from that savepoint if they want to commit side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1075883225
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org