You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/23 09:30:01 UTC

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1541: remove duplicated code

Technoboy- commented on issue #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568417376
 
 
   > > how about keeping the code the same ?
   > > like : add TableField in Alert class
   > 
   > I don't know，@TableField annotation，It is need to retain？ i think it's can remove for this project
   
   why did you keep it in AccessToken?  I think we should keep the same manager .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services