You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ChrisHegarty (via GitHub)" <gi...@apache.org> on 2024/07/10 11:40:19 UTC
[PR] [9.x] Use a confined Arena for IOContext.READONCE (#13535) [lucene]
ChrisHegarty opened a new pull request, #13560:
URL: https://github.com/apache/lucene/pull/13560
Backport of:
* #13535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] [9.x] Use a confined Arena for IOContext.READONCE (#13535) [lucene]
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty merged PR #13560:
URL: https://github.com/apache/lucene/pull/13560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] [9.x] Use a confined Arena for IOContext.READONCE (#13535) [lucene]
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on code in PR #13560:
URL: https://github.com/apache/lucene/pull/13560#discussion_r1672214121
##########
lucene/core/src/test/org/apache/lucene/store/TestMMapDirectory.java:
##########
@@ -141,4 +146,57 @@ public void testWithRandom() throws Exception {
}
}
}
+
+ // Opens the input with IOContext.READONCE to ensure slice and clone are appropriately confined
+ public void testConfined() throws Exception {
+ assumeTrue("Only testable with memory segments", Runtime.version().feature() >= 19);
Review Comment:
ah ha! that is what I was looking for. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] [9.x] Use a confined Arena for IOContext.READONCE (#13535) [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on code in PR #13560:
URL: https://github.com/apache/lucene/pull/13560#discussion_r1672135733
##########
lucene/core/src/test/org/apache/lucene/store/TestMMapDirectory.java:
##########
@@ -141,4 +146,57 @@ public void testWithRandom() throws Exception {
}
}
}
+
+ // Opens the input with IOContext.READONCE to ensure slice and clone are appropriately confined
+ public void testConfined() throws Exception {
+ assumeTrue("Only testable with memory segments", Runtime.version().feature() >= 19);
Review Comment:
Use `isMemorySegmentImpl()`, see https://github.com/apache/lucene/blob/9e5d278cd6e6f17f09dea8d05295008c855c971a/lucene/core/src/test/org/apache/lucene/store/TestMMapDirectory.java#L67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org