[GitHub] [apisix] spacewander commented on a diff in pull request #8200: fix: can not modify x-forwarded-host in proxy rewrite

[GitBox <gi...@apache.org>]

spacewander commented on code in PR #8200:
URL: https://github.com/apache/apisix/pull/8200#discussion_r1009069289


##########
t/plugin/proxy-rewrite.t:
##########
@@ -1311,3 +1311,56 @@ host: test.com:6443
 x-real-ip: 127.0.0.1
 --- no_error_log
 [error]
+
+
+
+=== TEST 45: set route(rewrite host)
+--- config

Review Comment:
   Let's add new test to https://github.com/apache/apisix/blob/master/t/plugin/proxy-rewrite3.t



##########
t/plugin/proxy-rewrite.t:
##########
@@ -1311,3 +1311,56 @@ host: test.com:6443
 x-real-ip: 127.0.0.1
 --- no_error_log
 [error]
+
+
+
+=== TEST 45: set route(rewrite host)

Review Comment:
   The title is incorrect. We don't rewrite the host



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org