You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/06/23 10:08:22 UTC
[GitHub] [cassandra] bereng opened a new pull request #1082: Cassandra 16758 4.0.0
bereng opened a new pull request #1082:
URL: https://github.com/apache/cassandra/pull/1082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng closed pull request #1082: Cassandra 16758 4.0.0
Posted by GitBox <gi...@apache.org>.
bereng closed pull request #1082:
URL: https://github.com/apache/cassandra/pull/1082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz commented on a change in pull request #1082: Cassandra 16758 4.0.0
Posted by GitBox <gi...@apache.org>.
maedhroz commented on a change in pull request #1082:
URL: https://github.com/apache/cassandra/pull/1082#discussion_r657258780
##########
File path: test/unit/org/apache/cassandra/transport/ClientResourceLimitsTest.java
##########
@@ -215,9 +215,9 @@ private void backPressureTest(Runnable limitLifter, Consumer<ClientResourceLimit
// When the client attempts to execute the second query, the backpressure
// mechanism should report the client connection is paused
assertTrue(started.await(5, TimeUnit.SECONDS));
- spinAssertEquals("Timed out after waiting 5 seconds for paused " +
+ spinAssertEquals("Timed out after waiting 10 seconds for paused " +
"connections metric to increment due to backpressure",
- before + 1, pausedConnections::getValue, 5, TimeUnit.SECONDS);
+ true, () -> pausedConnections.getValue() >= before + 1, 10, TimeUnit.SECONDS);
Review comment:
I think we can leave the stricter check in place if we just avoid doing driver initialization.
See https://github.com/apache/cassandra/pull/1045/files#diff-c801dfb00bc39ce5bf66a5876779350dba35def185588d13f5e492b6d79212f7R77 and https://github.com/apache/cassandra/pull/1045/files#diff-822707a68576bd683b72fde39e19ab8a78ed5a1816d95f5d8a00b3f46ac78d03R419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on a change in pull request #1082: Cassandra 16758 4.0.0
Posted by GitBox <gi...@apache.org>.
bereng commented on a change in pull request #1082:
URL: https://github.com/apache/cassandra/pull/1082#discussion_r659557049
##########
File path: test/unit/org/apache/cassandra/transport/ClientResourceLimitsTest.java
##########
@@ -215,9 +215,9 @@ private void backPressureTest(Runnable limitLifter, Consumer<ClientResourceLimit
// When the client attempts to execute the second query, the backpressure
// mechanism should report the client connection is paused
assertTrue(started.await(5, TimeUnit.SECONDS));
- spinAssertEquals("Timed out after waiting 5 seconds for paused " +
+ spinAssertEquals("Timed out after waiting 10 seconds for paused " +
"connections metric to increment due to backpressure",
- before + 1, pausedConnections::getValue, 5, TimeUnit.SECONDS);
+ true, () -> pausedConnections.getValue() >= before + 1, 10, TimeUnit.SECONDS);
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #1082: Cassandra 16758 4.0.0
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #1082:
URL: https://github.com/apache/cassandra/pull/1082#issuecomment-866711460
- CI [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/366/workflows/bd235fe8-9339-42d0-8bcb-9a53e008b383)
- CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/366/workflows/75406e68-d74c-40f4-b717-85838d62890d)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #1082: Cassandra 16758 4.0.0
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #1082:
URL: https://github.com/apache/cassandra/pull/1082#issuecomment-869456430
Closed in favor of Caleb's proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng edited a comment on pull request #1082: Cassandra 16758 4.0.0
Posted by GitBox <gi...@apache.org>.
bereng edited a comment on pull request #1082:
URL: https://github.com/apache/cassandra/pull/1082#issuecomment-866711460
- CI [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/366/workflows/bd235fe8-9339-42d0-8bcb-9a53e008b383)
- CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/366/workflows/75406e68-d74c-40f4-b717-85838d62890d) (notice failures are from a different/unrelated test method)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org