You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/10 08:56:33 UTC
[GitHub] [spark] beliefer opened a new pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
beliefer opened a new pull request #34543:
URL: https://github.com/apache/spark/pull/34543
### What changes were proposed in this pull request?
The current implementation of persistent view is create hive table with view text.
The view text is just a query string, so the hackers may tamper with it through various means.
Such as, `select * from tab1` tampered with `drop table tab1`.
### Why are the changes needed?
First, the view text is query string, `parser.parsePlan(viewText)` occurs more overhead than `parser.parseQuery(viewText)`.
Second, the view text can be tampered by hackers and issue security vulnerabilities.
### Does this PR introduce _any_ user-facing change?
'No'. Unless hackers tamper view text, user will not see any change.
### How was this patch tested?
New tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967790208
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145178/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965222619
**[Test build #145064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145064/testReport)** for PR 34543 at commit [`b3f898c`](https://github.com/apache/spark/commit/b3f898c83ff695fb6e3a32e89b3d195a24ce6105).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966461360
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49583/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965650621
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145064/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966157729
ping @MaxGekk @gengliangwang
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967752729
**[Test build #145178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145178/testReport)** for PR 34543 at commit [`0f46831`](https://github.com/apache/spark/commit/0f46831ec573ab90b72ffd917a773ebdd840e17f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-964997930
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49524/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966851504
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49608/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965480367
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49534/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-964920187
**[Test build #145054 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145054/testReport)** for PR 34543 at commit [`dc46ba4`](https://github.com/apache/spark/commit/dc46ba4ffa445bf92e647390889837b953168856).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34543:
URL: https://github.com/apache/spark/pull/34543#discussion_r747453602
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
##########
@@ -324,4 +324,20 @@ class HiveCommandSuite extends QueryTest with SQLTestUtils with TestHiveSingleto
FsConstants.LOCAL_FS_URI, workingDir, new Path("kv1.txt"))
assert(r === new Path(s"$workingDir/kv1.txt"))
}
+
+ test("SPARK-37266: Optimize the analysis for view text of persistent view and" +
+ " fix security vulnerabilities caused by sql tampering") {
+ val table = hiveContext.sessionState.catalog.getTableMetadata(TableIdentifier("parquet_view1"))
Review comment:
can we create a new view to test it instead of altering an existing view?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966777029
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49597/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-968982825
thanks, merging to master/3.2!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966741491
**[Test build #145126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145126/testReport)** for PR 34543 at commit [`81f0ba1`](https://github.com/apache/spark/commit/81f0ba1ff1d54f0f3fe2e1cf4601d3bbd2674b18).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966792496
**[Test build #145137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145137/testReport)** for PR 34543 at commit [`1d8495c`](https://github.com/apache/spark/commit/1d8495c7bec8e9b0855fb83ad16f56b481f50f80).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967560189
**[Test build #145169 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145169/testReport)** for PR 34543 at commit [`77cbbdf`](https://github.com/apache/spark/commit/77cbbdf9c257c731e09b955c9b468a6ee3a9ed45).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966470985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966379188
**[Test build #145113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145113/testReport)** for PR 34543 at commit [`a51a184`](https://github.com/apache/spark/commit/a51a184fc1f4eba61b89af9acd1d0b51f0787104).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967311408
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49639/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-964920187
**[Test build #145054 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145054/testReport)** for PR 34543 at commit [`dc46ba4`](https://github.com/apache/spark/commit/dc46ba4ffa445bf92e647390889837b953168856).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967766557
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49647/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966875658
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145126/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967270311
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49639/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965020872
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49524/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965020872
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49524/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966784676
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49597/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34543:
URL: https://github.com/apache/spark/pull/34543#discussion_r747953355
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
##########
@@ -324,4 +324,23 @@ class HiveCommandSuite extends QueryTest with SQLTestUtils with TestHiveSingleto
FsConstants.LOCAL_FS_URI, workingDir, new Path("kv1.txt"))
assert(r === new Path(s"$workingDir/kv1.txt"))
}
+
+ test("SPARK-37266: Optimize the analysis for view text of persistent view and" +
+ " fix security vulnerabilities caused by sql tampering") {
+ sql("CREATE VIEW parquet_view2 as select * from parquet_tab4")
Review comment:
can be simpler `CREATE VIEW v AS SELECT 1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966821062
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49608/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966908754
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145137/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-969066031
@cloud-fan Thank you for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965222581
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145054/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34543:
URL: https://github.com/apache/spark/pull/34543#discussion_r747452400
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -877,7 +877,12 @@ class SessionCatalog(
}
val viewConfigs = metadata.viewSQLConfigs
val parsedPlan = SQLConf.withExistingConf(View.effectiveSQLConf(viewConfigs, isTempView)) {
- parser.parsePlan(viewText)
+ try {
+ parser.parseQuery(viewText)
+ } catch {
+ case _: ParseException => throw new AnalysisException(
+ s"Invalid view text of view ${metadata.qualifiedName}, it may have been tampered with")
Review comment:
shall we display the view sql text as wel?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34543:
URL: https://github.com/apache/spark/pull/34543#discussion_r747953170
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
##########
@@ -324,4 +324,23 @@ class HiveCommandSuite extends QueryTest with SQLTestUtils with TestHiveSingleto
FsConstants.LOCAL_FS_URI, workingDir, new Path("kv1.txt"))
assert(r === new Path(s"$workingDir/kv1.txt"))
}
+
+ test("SPARK-37266: Optimize the analysis for view text of persistent view and" +
+ " fix security vulnerabilities caused by sql tampering") {
+ sql("CREATE VIEW parquet_view2 as select * from parquet_tab4")
+ val table = hiveContext.sessionState.catalog.getTableMetadata(TableIdentifier("parquet_view2"))
+ try {
+ // Simulate the behavior of hackers
+ val tamperedViewText = "drop view parquet_view2"
+ val tamperedTable = table.copy(viewText = Some(tamperedViewText))
+ hiveContext.sessionState.catalog.alterTable(tamperedTable)
Review comment:
Seems like we can run this test in sql/core, as it does not rely on hive. Can we move it to `PersistedViewTestSuite`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966792496
**[Test build #145137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145137/testReport)** for PR 34543 at commit [`1d8495c`](https://github.com/apache/spark/commit/1d8495c7bec8e9b0855fb83ad16f56b481f50f80).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966907552
**[Test build #145137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145137/testReport)** for PR 34543 at commit [`1d8495c`](https://github.com/apache/spark/commit/1d8495c7bec8e9b0855fb83ad16f56b481f50f80).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967770095
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49647/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967770095
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49647/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966759454
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49597/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966741491
**[Test build #145126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145126/testReport)** for PR 34543 at commit [`81f0ba1`](https://github.com/apache/spark/commit/81f0ba1ff1d54f0f3fe2e1cf4601d3bbd2674b18).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967790208
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145178/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965403796
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49534/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965310746
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49534/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965217498
**[Test build #145054 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145054/testReport)** for PR 34543 at commit [`dc46ba4`](https://github.com/apache/spark/commit/dc46ba4ffa445bf92e647390889837b953168856).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34543:
URL: https://github.com/apache/spark/pull/34543#discussion_r747990201
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewTestSuite.scala
##########
@@ -530,4 +530,23 @@ class PersistedViewTestSuite extends SQLViewTestSuite with SharedSparkSession {
spark.sessionState.conf.clear()
}
}
+
+ test("SPARK-37266: Optimize the analysis for view text of persistent view and" +
+ " fix security vulnerabilities caused by sql tampering") {
Review comment:
we can shorten the test name: `SPARK-37266: view text can only be SELECT queries`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966784676
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49597/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967236084
**[Test build #145169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145169/testReport)** for PR 34543 at commit [`77cbbdf`](https://github.com/apache/spark/commit/77cbbdf9c257c731e09b955c9b468a6ee3a9ed45).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-968982825
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34543:
URL: https://github.com/apache/spark/pull/34543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967789997
**[Test build #145178 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145178/testReport)** for PR 34543 at commit [`0f46831`](https://github.com/apache/spark/commit/0f46831ec573ab90b72ffd917a773ebdd840e17f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965648596
**[Test build #145064 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145064/testReport)** for PR 34543 at commit [`b3f898c`](https://github.com/apache/spark/commit/b3f898c83ff695fb6e3a32e89b3d195a24ce6105).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-964954414
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49524/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965222581
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145054/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967566770
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145169/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967236084
**[Test build #145169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145169/testReport)** for PR 34543 at commit [`77cbbdf`](https://github.com/apache/spark/commit/77cbbdf9c257c731e09b955c9b468a6ee3a9ed45).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967566770
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145169/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967752729
**[Test build #145178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145178/testReport)** for PR 34543 at commit [`0f46831`](https://github.com/apache/spark/commit/0f46831ec573ab90b72ffd917a773ebdd840e17f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34543:
URL: https://github.com/apache/spark/pull/34543#discussion_r747452726
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -877,7 +877,12 @@ class SessionCatalog(
}
val viewConfigs = metadata.viewSQLConfigs
val parsedPlan = SQLConf.withExistingConf(View.effectiveSQLConf(viewConfigs, isTempView)) {
- parser.parsePlan(viewText)
+ try {
+ parser.parseQuery(viewText)
+ } catch {
+ case _: ParseException => throw new AnalysisException(
+ s"Invalid view text of view ${metadata.qualifiedName}, it may have been tampered with")
Review comment:
and let's move the error to `QueryCompilationErrors.scala`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966470985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966835393
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49608/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966851504
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49608/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966875658
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145126/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967760254
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49647/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34543:
URL: https://github.com/apache/spark/pull/34543#discussion_r747987487
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewTestSuite.scala
##########
@@ -530,4 +530,23 @@ class PersistedViewTestSuite extends SQLViewTestSuite with SharedSparkSession {
spark.sessionState.conf.clear()
}
}
+
+ test("SPARK-37266: Optimize the analysis for view text of persistent view and" +
+ " fix security vulnerabilities caused by sql tampering") {
+ sql("CREATE VIEW v AS SELECT 1")
+ val table = spark.sessionState.catalog.getTableMetadata(TableIdentifier("v"))
Review comment:
let's wrap the test with `withView`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967317372
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49639/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34543: [SPARK-37266][SQL] View text can only be SELECT queries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-967317372
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49639/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966859374
**[Test build #145126 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145126/testReport)** for PR 34543 at commit [`81f0ba1`](https://github.com/apache/spark/commit/81f0ba1ff1d54f0f3fe2e1cf4601d3bbd2674b18).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966908754
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145137/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965480367
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49534/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965650621
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145064/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966379188
**[Test build #145113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145113/testReport)** for PR 34543 at commit [`a51a184`](https://github.com/apache/spark/commit/a51a184fc1f4eba61b89af9acd1d0b51f0787104).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966419055
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49583/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-966463026
**[Test build #145113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145113/testReport)** for PR 34543 at commit [`a51a184`](https://github.com/apache/spark/commit/a51a184fc1f4eba61b89af9acd1d0b51f0787104).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34543: [SPARK-37266][SQL] Optimize the analysis for view text of persistent view and fix security vulnerabilities caused by sql tampering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34543:
URL: https://github.com/apache/spark/pull/34543#issuecomment-965222619
**[Test build #145064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145064/testReport)** for PR 34543 at commit [`b3f898c`](https://github.com/apache/spark/commit/b3f898c83ff695fb6e3a32e89b3d195a24ce6105).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org