You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/18 12:09:00 UTC
[GitHub] [incubator-nuttx] zhuyanlinzyl opened a new pull request #4683: arch:xtens:mpu: modify acc and memtype to uint32_t
zhuyanlinzyl opened a new pull request #4683:
URL: https://github.com/apache/incubator-nuttx/pull/4683
The type uint8_t and type uint16_t will overflow in `MPU_ENTRY_AR` marco.
Change-Id: I2f660c13740fea725a076f7f208214aedc5ca0ee
## Summary
## Impact
## Testing
testing pass in xtensa with mpu enable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4683: arch:xtens:mpu: modify acc and memtype to uint32_t
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4683:
URL: https://github.com/apache/incubator-nuttx/pull/4683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4683: arch:xtens:mpu: modify acc and memtype to uint32_t
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4683:
URL: https://github.com/apache/incubator-nuttx/pull/4683#discussion_r730878614
##########
File path: arch/xtensa/src/common/mpu.h
##########
@@ -210,7 +210,7 @@ void mpu_control(bool enable);
****************************************************************************/
void mpu_configure_region(uintptr_t base, size_t size,
- uint8_t acc, uint16_t memtype);
+ uint32_t acc, uint32_t memtype);
Review comment:
```suggestion
uint32_t acc, uint32_t memtype);
```
nit: adjust the code alignment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4683: arch:xtens:mpu: modify acc and memtype to uint32_t
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4683:
URL: https://github.com/apache/incubator-nuttx/pull/4683#discussion_r730879110
##########
File path: arch/xtensa/src/common/xtensa_mpu.c
##########
@@ -94,7 +94,7 @@ void mpu_control(bool enable)
****************************************************************************/
void mpu_configure_region(uintptr_t base, size_t size,
- uint8_t acc, uint16_t memtype)
+ uint32_t acc, uint32_t memtype)
Review comment:
```suggestion
uint32_t acc, uint32_t memtype);
```
nit: adjust the code alignment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4683: arch:xtens:mpu: modify acc and memtype to uint32_t
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4683:
URL: https://github.com/apache/incubator-nuttx/pull/4683#discussion_r730878614
##########
File path: arch/xtensa/src/common/mpu.h
##########
@@ -210,7 +210,7 @@ void mpu_control(bool enable);
****************************************************************************/
void mpu_configure_region(uintptr_t base, size_t size,
- uint8_t acc, uint16_t memtype);
+ uint32_t acc, uint32_t memtype);
Review comment:
```suggestion
uint32_t acc, uint32_t memtype);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org