[GitHub] [tvm-rfcs] areusch commented on pull request #7: [UnitTests] Parametrized Unit Tests

[GitBox <gi...@apache.org>]

areusch commented on pull request #7:
URL: https://github.com/apache/tvm-rfcs/pull/7#issuecomment-858910805


   @Lunderberg I think there were two open items from the discuss post:
   1. shadowing local vars with module-level vars containing their fixtures
   2. caching non-serializable data
   
   on 1, it sounds like you had found a solution, so I think we're resolved there.
   
   on 2, you'd suggested to table the discussion of how to cache non-serializable objects and just cache serializable ones. that sounds great to me.
   
   so then, the real reason I was having this debate with you: i'd like to propose that in all cases (cache hot or cold), we always provide test functions with a brand-new deserialized copy of the data. i think that solves all of my concerns around tests poisoning downstream tests with cached data, and hopefully has not-too-significant performance impact. what are your thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org