[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6577: Fix the SIGSEGV for large index

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #6577:
URL: https://github.com/apache/incubator-pinot/pull/6577#discussion_r575607930



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/segment/store/SingleFileIndexDirectory.java
##########
@@ -258,15 +255,15 @@ private void mapBufferEntries()
       IndexEntry entry = offsetEntry.getValue();
       runningSize += entry.size;
 
-      if (runningSize >= MAX_ALLOCATION_SIZE) {
+      if (runningSize >= MAX_ALLOCATION_SIZE && !offsetAccum.isEmpty()) {

Review comment:
       Without this check, if the size of the first index is over 2G, it will throw exception because `offsetAccum` is empty.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org