You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "Kusuma04-dev (via GitHub)" <gi...@apache.org> on 2025/08/20 09:30:41 UTC
[PR] kie-issues# 3247: Add i18n for dmn-editor-standalone package [incubator-kie-tools]
Kusuma04-dev opened a new pull request, #3248:
URL: https://github.com/apache/incubator-kie-tools/pull/3248
closes https://github.com/apache/incubator-kie-tools/issues/3247,
Added locale and i18n for dmn-editor-standalone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues# 3247: Add i18n for dmn-editor-standalone package [incubator-kie-tools]
Posted by "Kusuma04-dev (via GitHub)" <gi...@apache.org>.
Kusuma04-dev commented on code in PR #3248:
URL: https://github.com/apache/incubator-kie-tools/pull/3248#discussion_r2291855407
##########
packages/dmn-editor-standalone/src/index.ts:
##########
@@ -97,7 +99,7 @@ export function open(args: {
getFileContents: () => Promise.resolve(args.initialContent),
isReadOnly: args.readOnly ?? false,
},
- "en-US",
+ updated_locale,
Review Comment:
Thanks for the review @ljmotta .i have made changes suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues# 3247: Add i18n for dmn-editor-standalone package [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #3248:
URL: https://github.com/apache/incubator-kie-tools/pull/3248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues# 3247: Add i18n for dmn-editor-standalone package [incubator-kie-tools]
Posted by "ljmotta (via GitHub)" <gi...@apache.org>.
ljmotta commented on code in PR #3248:
URL: https://github.com/apache/incubator-kie-tools/pull/3248#discussion_r2291156373
##########
packages/dmn-editor-standalone/src/index.ts:
##########
@@ -97,7 +99,7 @@ export function open(args: {
getFileContents: () => Promise.resolve(args.initialContent),
isReadOnly: args.readOnly ?? false,
},
- "en-US",
+ updated_locale,
Review Comment:
Please, inline the variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org